This reverts commit c3b06d0c393e533eab712922911d14e5a079fa5d.
Reason for revert: Caused miscompiles when inserting assume for undef.
Also adds a test to prevent similar breakage in future.
Fixes PR44154.
Paths
| Differential D70933
Revert "[InstCombine] keep assumption before sinking calls" ClosedPublic Authored by inglorion on Dec 2 2019, 5:36 PM.
Details Summary This reverts commit c3b06d0c393e533eab712922911d14e5a079fa5d. Reason for revert: Caused miscompiles when inserting assume for undef. Also adds a test to prevent similar breakage in future. Fixes PR44154.
Diff Detail
Event TimelineComment Actions Add the test case that miscompiled, maybe keep a modified assume-replacing-call.ll test case with a fixme, and then remove the assume code. (= I'm fine with this) This revision is now accepted and ready to land.Dec 3 2019, 3:57 PM Closed by commit rG055779a9ac11: Revert "[InstCombine] keep assumption before sinking calls" (authored by inglorion). · Explain WhyDec 5 2019, 10:52 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 232396 llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
llvm/test/Transforms/InstCombine/assume-replacing-call.ll
llvm/test/Transforms/InstCombine/unused-nonnull.ll
|