Page MenuHomePhabricator

[Matrix] Update shape propagation to iterate until done.
Needs ReviewPublic

Authored by fhahn on Mon, Dec 2, 5:59 AM.

Details

Summary

This patch updates the shape propagation to iterate until no new shape
information is discovered.

As initial seed for the forward propagation, we use the matrix intrinsic
instructions. Both propagateShapeForward and propagateShapeBackward
return new work lists, with the instructions to be used for the next
iteration. When propagating forward, we record all instructions we added
new shape information for. When propagating backward, we record all
users of instructions we added new shape information for.

Diff Detail

Event Timeline

fhahn created this revision.Mon, Dec 2, 5:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Dec 2, 5:59 AM
Herald added a subscriber: hiraditya. · View Herald Transcript

Build result: FAILURE - Could not check out parent git hash "bc8e8995246e421e2c1b2f415685f8c86bf0aeb0". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch instead...

ERROR: arc patch failed with error code 1. Check build log for details.
Log files: console-log.txt, CMakeCache.txt

reames resigned from this revision.Mon, Dec 2, 4:50 PM
LuoYuanke added inline comments.Wed, Dec 11, 5:38 AM
llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
461

Do we miss the original op ( matrix_multiply, matrix_transpose ...) in backward?