Page MenuHomePhabricator

[lit] Be more explicit about the state of tests
ClosedPublic

Authored by yln on Nov 22 2019, 11:20 AM.

Details

Summary

Tests go through the following stages:

*) discovered
*) filtered
*) executed

Only executed tests have a result (e.g., PASS, FAIL, XFAIL, etc.). See
"result codes" in Test.py.

Diff Detail

Event Timeline

yln created this revision.Nov 22 2019, 11:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 22 2019, 11:20 AM

@yln It's still useful to know which tests are marked as UNSUPPORTED without actually running the tests. Does this change break that workflow?

yln added a comment.Nov 22 2019, 4:17 PM

@yln It's still useful to know which tests are marked as UNSUPPORTED without actually running the tests. Does this change break that workflow?

This change is NFCI. It just gives variables better names so it's easier to tell what tests actually is.

rnk accepted this revision.Nov 26 2019, 11:21 AM

lgtm

This revision is now accepted and ready to land.Nov 26 2019, 11:21 AM
This revision was automatically updated to reflect the committed changes.