Change while to do-while

[pi1024e]

Summary

The assert statement says that the location must be a macroID, which is true. However, the while statements checks for that again, which is unnecessary, and gives warnings for returning a potentially non-initialized variable. For this reason, I suggest changing the while to a do-while loop while keeping the assert where it is.

[lebedev.ri]

Missing a test; please upload all patches with full context (-U99999)

[pi1024e]

What do you mean? I test compiled this and there were no errors after running the test benchmark. Was I supposed to do something else?

[xbolva00]

This is fine as NFC/NFCI patch.

[pi1024e]

Any updates?

[pi1024e]

@MaskRay it's been months yet this hasn't landed yet. Why?

[MaskRay]

In D70603#2114361, @pi1024e wrote:

@MaskRay it's been months yet this hasn't landed yet. Why?

It is usually assumed that the patch author pushes this commit. In this case, it seems that you don't have commit access. You'll need to provide 'Name <email>' and I can push it for you.

[pi1024e]

This comment was removed by pi1024e.

[pi1024e]

This comment was removed by pi1024e.

clang/lib/Analysis/ReachableCode.cpp

 static SourceLocation getTopMostMacro(SourceLocation Loc, SourceManager &SM) {
   assert(Loc.isMacroID());
   SourceLocation Last;
-  while (Loc.isMacroID()) {
+  do {
     Last = Loc;
     Loc = SM.getImmediateMacroCallerLoc(Loc);
-  }
+  } while (Loc.isMacroID());
   return Last;
 }