Page MenuHomePhabricator

[Object][RISCV] Fix R_RISCV_SET6 and R_RISCV_SUB6 relocations resolution
ClosedPublic

Authored by luismarques on Nov 18 2019, 7:17 AM.

Details

Summary

These relocations had a suspicious resolution logic, given their name. This patch
makes the resolution match the LLD one, which makes more sense.

Diff Detail

Event Timeline

luismarques created this revision.Nov 18 2019, 7:17 AM

Yes that looks rather better. Especially SET6 which was previously an ADD6 (although that aspect was likely harmless as nothing sensible would put something there just to be clobbered by a SET6).

LGTM. Do you have any test case for this patch?

LGTM. Do you have any test case for this patch?

There is one now: D70541.

HsiangKai accepted this revision.Nov 21 2019, 8:55 AM

Thanks for your patch.

This revision is now accepted and ready to land.Nov 21 2019, 8:55 AM
This revision was automatically updated to reflect the committed changes.