Page MenuHomePhabricator

[scudo][standalone] Enabled SCUDO_DEBUG for tests + fixes
ClosedPublic

Authored by cryptoad on Nov 14 2019, 2:34 PM.

Details

Summary

SCUDO_DEBUG was not enabled for unit tests, meaning the DCHECKs
were never tripped. While turning this on, I discovered that a few
of those not-exercised checks were actually wrong. This CL addresses
those incorrect checks.

Not that to work in tests CHECK_IMPL has to explicitely use the
scudo namespace. Also changes a C cast to a C++ cast.

Diff Detail

Event Timeline

cryptoad created this revision.Nov 14 2019, 2:34 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 14 2019, 2:34 PM
Herald added subscribers: Restricted Project, mgorny. · View Herald Transcript
hctim accepted this revision.Nov 14 2019, 2:57 PM
This revision is now accepted and ready to land.Nov 14 2019, 2:57 PM
This revision was automatically updated to reflect the committed changes.