[yaml2obj][test] Move tests to binary format specific subdirectories

[MaskRay]

Summary

Create COFF/, ELF/, and Minidump and move tests there.

Also

• Rename *.test to *.yaml
• For yaml2obj RUN lines, use -o %t instead of > %t for consistency. We still have tests that check stdout is the default output, e.g. multi-doc.test
• Update tests to consistently use ## for comments. # is for RUN and CHECK lines.
• Merge symboless-relocation.yaml and invalid-symboless-relocation.yaml to ELF/relocation-implicit-symbol-index.test

[jhenderson]

Mostly looks fine to me.

llvm/test/tools/yaml2obj/ELF/symbol-index-invalid.yaml

1–2

Maybe add "in a symbol".

llvm/test/tools/yaml2obj/ELF/verdef-section.yaml

2

Delete "the".

llvm/test/tools/yaml2obj/ELF/verneed-section.yaml

2

Delete "the".

llvm/test/tools/yaml2obj/empty-symbols.yaml

10

I might be misreading the intent of the comment, but I think there's value in testing:

Symbols:

distinctly from

Symbols: []

In other words, can yaml2obj handle it with/without the [].

[MaskRay]

Address review comments

llvm/test/tools/yaml2obj/empty-symbols.yaml

10

We probably don't have other tests that check Symbols: with the value omitted now.

Added it back with a comment.

[grimar]

Nice cleanup! I've found only a single minor nit.

llvm/test/tools/yaml2obj/ELF/empty-symbols.yaml

11

# -> ##

[jhenderson]

LGTM, with one suggestion.

llvm/test/tools/yaml2obj/ELF/empty-symbols.yaml

11

This phrasing sounds a bit clunky to me. How about "... but here we show that the value can be omitted."

[MaskRay]

Address review comments

llvm/test/tools/yaml2obj/COFF/basic-arm64.yaml

 # RUN: yaml2obj %s -o %t
 # RUN: llvm-readobj --file-headers %t | FileCheck %s
 # RUN: obj2yaml %t | FileCheck %s --check-prefix=ROUNDTRIP
 
 # CHECK: OptionalHeaderSize: 240
 
 # ROUNDTRIP: VirtualAddress:  4096
 # ROUNDTRIP: VirtualAddress:  8192
 # ROUNDTRIP: VirtualAddress:  12288
 
 --- !COFF
-OptionalHeader:  
+OptionalHeader:
   AddressOfEntryPoint: 4096
   ImageBase:       1073741824
   SectionAlignment: 4096
   FileAlignment:   512
   MajorOperatingSystemVersion: 6
   MinorOperatingSystemVersion: 0
   MajorImageVersion: 0
   MinorImageVersion: 0
   MajorSubsystemVersion: 6
   MinorSubsystemVersion: 0
   Subsystem:       IMAGE_SUBSYSTEM_WINDOWS_CUI
   DLLCharacteristics: [ IMAGE_DLL_CHARACTERISTICS_HIGH_ENTROPY_VA, IMAGE_DLL_CHARACTERISTICS_DYNAMIC_BASE, IMAGE_DLL_CHARACTERISTICS_NX_COMPAT, IMAGE_DLL_CHARACTERISTICS_TERMINAL_SERVER_AWARE ]
   SizeOfStackReserve: 1048576
   SizeOfStackCommit: 4096
   SizeOfHeapReserve: 1048576
   SizeOfHeapCommit: 4096
-  ExportTable:     
+  ExportTable:
     RelativeVirtualAddress: 0
     Size:            0
-  ImportTable:     
+  ImportTable:
     RelativeVirtualAddress: 0
     Size:            0
-  ResourceTable:   
+  ResourceTable:
     RelativeVirtualAddress: 0
     Size:            0
-  ExceptionTable:  
+  ExceptionTable:
     RelativeVirtualAddress: 12288
     Size:            8
-  CertificateTable: 
+  CertificateTable:
     RelativeVirtualAddress: 0
     Size:            0
-  BaseRelocationTable: 
+  BaseRelocationTable:
     RelativeVirtualAddress: 0
     Size:            0
-  Debug:           
+  Debug:
     RelativeVirtualAddress: 0
     Size:            0
-  Architecture:    
+  Architecture:
     RelativeVirtualAddress: 0
     Size:            0
-  GlobalPtr:       
+  GlobalPtr:
     RelativeVirtualAddress: 0
     Size:            0
-  TlsTable:        
+  TlsTable:
     RelativeVirtualAddress: 0
     Size:            0
-  LoadConfigTable: 
+  LoadConfigTable:
     RelativeVirtualAddress: 0
     Size:            0
-  BoundImport:     
+  BoundImport:
     RelativeVirtualAddress: 0
     Size:            0
-  IAT:             
+  IAT:
     RelativeVirtualAddress: 0
     Size:            0
-  DelayImportDescriptor: 
+  DelayImportDescriptor:
     RelativeVirtualAddress: 0
     Size:            0
-  ClrRuntimeHeader: 
+  ClrRuntimeHeader:
     RelativeVirtualAddress: 0
     Size:            0
-header:          
+header:
   Machine:         IMAGE_FILE_MACHINE_ARM64
   Characteristics: [ IMAGE_FILE_EXECUTABLE_IMAGE, IMAGE_FILE_LARGE_ADDRESS_AWARE ]
-sections:        
+sections:
   - Name:            .text
     Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
     VirtualAddress:  4096
     VirtualSize:     4
     SectionData:     C0035FD6
   - Name:            .rdata
     Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_MEM_READ ]
     VirtualAddress:  8192

llvm/test/tools/yaml2obj/COFF/invalid-alignment.yaml

 # RUN: not yaml2obj %s 2>&1 | FileCheck %s
 
 ## CHECK: error: section alignment is too large
 
 --- !COFF
 header:
   Machine:         IMAGE_FILE_MACHINE_AMD64
   Characteristics: []
 sections:
   - Name:            '.text'
     Characteristics: []
     SectionData:     00
     Alignment:       16384
-symbols:
+symbols: []

llvm/test/tools/yaml2obj/COFF/symbol-index.yaml

 # RUN: yaml2obj %s -o %t
 # RUN: llvm-readobj -r %t | FileCheck %s --check-prefix=RELOCS
 # RUN: obj2yaml %t | FileCheck %s --check-prefix=YAML
 
 # RELOCS:      Relocations [
 # RELOCS-NEXT:   Section (1) .text {
 # RELOCS-NEXT:     0x3 IMAGE_REL_AMD64_REL32 .rdata (0)
 # RELOCS-NEXT:     0xA IMAGE_REL_AMD64_REL32 .rdata (1)
 # RELOCS-NEXT:     0x11 IMAGE_REL_AMD64_REL32 foo (2)
 # RELOCS-NEXT:   }
 # RELOCS-NEXT: ]
 
-# Check that we usually output relocations with SymbolName.
-# For relocations with a non-unique symbol name, output
-# SymbolTableIndex instead.
+## Check that we usually output relocations with SymbolName.
+## For relocations with a non-unique symbol name, output
+## SymbolTableIndex instead.
 
-# YAML:          Relocations:     
+# YAML:          Relocations:
 # YAML-NEXT:       - VirtualAddress:  3
 # YAML-NEXT:         SymbolTableIndex: 0
 # YAML-NEXT:         Type:            IMAGE_REL_AMD64_REL32
 # YAML-NEXT:       - VirtualAddress:  10
 # YAML-NEXT:         SymbolTableIndex: 1
 # YAML-NEXT:         Type:            IMAGE_REL_AMD64_REL32
 # YAML-NEXT:       - VirtualAddress:  17
 # YAML-NEXT:         SymbolName:      foo
 # YAML-NEXT:         Type:            IMAGE_REL_AMD64_REL32
 
 --- !COFF
-header:          
+header:
   Machine:         IMAGE_FILE_MACHINE_AMD64
   Characteristics: [  ]
-sections:        
+sections:
   - Name:            .text
     Characteristics: [  ]
     Alignment:       4
     SectionData:     488B0500000000488B0500000000488B0500000000
-    Relocations:     
+    Relocations:
       - VirtualAddress:  3
         SymbolTableIndex: 0
         Type:            IMAGE_REL_AMD64_REL32
       - VirtualAddress:  10
         SymbolTableIndex: 1
         Type:            IMAGE_REL_AMD64_REL32
       - VirtualAddress:  17
         SymbolName:      foo
         Type:            IMAGE_REL_AMD64_REL32
   - Name:            .rdata
     Characteristics: [  ]
     Alignment:       1
     SectionData:     '00'
   - Name:            .rdata
     Characteristics: [  ]
     Alignment:       1
     SectionData:     '01'
-symbols:         
+symbols:
   - Name:            .rdata
     Value:           0
     SectionNumber:   2
     SimpleType:      IMAGE_SYM_TYPE_NULL
     ComplexType:     IMAGE_SYM_DTYPE_NULL
     StorageClass:    IMAGE_SYM_CLASS_STATIC
   - Name:            .rdata
     Value:           0

llvm/test/tools/yaml2obj/ELF/abiversion.yaml

+## Check we are able to parse/emit the ABI version with yaml2obj/obj2yaml.
+
 # RUN: yaml2obj %s -o %t
 # RUN: llvm-readobj --file-headers %t | FileCheck %s --check-prefix=FROMYAML
 # RUN: obj2yaml %t | FileCheck %s --check-prefix=TOYAML
 
-## Check we are able to parse/emit the ABI version with yaml2obj/obj2yaml.
-
 # FROMYAML: ABIVersion: 5
 # TOYAML:   ABIVersion: 0x05
 
 --- !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_REL
   Machine:         EM_X86_64
   ABIVersion:      0x05

llvm/test/tools/yaml2obj/ELF/duplicate-section-names.yaml

- Name: .group
     Members:
       - SectionOrType: GRP_COMDAT
       - SectionOrType: .text.foo
   - Name: .text.foo
     Type: SHT_PROGBITS
   - Name: '.group [1]'
     Type: SHT_GROUP
     Info: 'foo [1]'
-    Members:         
+    Members:
       - SectionOrType: GRP_COMDAT
       - SectionOrType: '.text.foo [1]'
   - Name: '.text.foo [1]'
     Type: SHT_PROGBITS
 Symbols:
   - Name:    foo
     Section: .text.foo
   - Name:    'foo [1]'
     Section: '.text.foo [1]'

llvm/test/tools/yaml2obj/ELF/dynamic-section-raw-content.yaml

-# Show that yaml2obj can handle a dynamic section with raw content instead of
-# entries. Also show that it rejects raw content when entries are also provided.
+## Show that yaml2obj can handle a dynamic section with raw content instead of
+## entries. Also show that it rejects raw content when entries are also provided.
 
 # RUN: yaml2obj --docnum=1 %s -o %t1
 # RUN: llvm-readobj -x .dynamic --sections %t1 | FileCheck %s --check-prefix=RAW
 
 # RAW:      Name: .dynamic
 # RAW-NEXT: Type: SHT_DYNAMIC
 # RAW-NEXT: Flags [
 # RAW-NEXT: ]

llvm/test/tools/yaml2obj/ELF/dynamic-section.yaml

-# Ensures that dynamic section has sh_entsize correctly set
+## Ensures that dynamic section has sh_entsize correctly set.
+
 # RUN: yaml2obj %s -o %t
 # RUN: llvm-readobj --sections %t | FileCheck %s --check-prefix=SECTION
 
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_DYN
   Machine:         EM_X86_64
 Sections:
   - Name: .dynamic
     Type: SHT_DYNAMIC
     Flags: [ SHF_ALLOC, SHF_WRITE ]
 
 # SECTION: Name: .dynamic
 # SECTION: EntrySize: 16

llvm/test/tools/yaml2obj/ELF/dynamic-symbols.yaml

 # RUN: yaml2obj --docnum=2 %s -o %t2
 # RUN: llvm-readobj --dyn-symbols %t2 2>&1 | FileCheck -DFILE=%t2 %s --check-prefix=NUM
 
 # NUM:      Name: foo
 # NUM:      Section:
 # NUM-SAME: .data (0x1)
 
 # NUM:      Name: bar
-# NUM:      Section: 
+# NUM:      Section:
 # NUM-SAME: .strtab (0x2)
 
 # NUM:      Name: zed
 # NUM: warning: '[[FILE]]': invalid section index: 255
-# NUM:      Section: 
+# NUM:      Section:
 # NUM-SAME: <?> (0xFF)
 
 --- !ELF
 FileHeader:
   Class:   ELFCLASS64
   Data:    ELFDATA2LSB
   Type:    ET_DYN
   Machine: EM_X86_64

llvm/test/tools/yaml2obj/ELF/empty-symbols.yaml

+## Ensure yaml2obj doesn't error on empty optional mappings, such as Symbols
+# RUN: yaml2obj %s -o /dev/null
+
+!ELF
+FileHeader:
+  Class:           ELFCLASS64
+  Data:            ELFDATA2LSB
+  Type:            ET_DYN
+  Machine:         EM_X86_64
+## We usually express this as `Symbols: []`, but here we show that the value
+## can be omitted.
+Symbols:

llvm/test/tools/yaml2obj/ELF/linker-options.yaml

- Name: .linker-options
     Options:
       - Value: value
 
 ## Check we can't use both "Options" and "Content" together.
 
 # RUN: not yaml2obj %s --docnum=4 2>&1 | FileCheck %s --check-prefix=BOTH
 
 # BOTH: error: "Options" and "Content" can't be used together
- 
 --- !ELF
 FileHeader:
   Class:   ELFCLASS64
   Data:    ELFDATA2LSB
   Type:    ET_REL
   Machine: EM_X86_64
 Sections:
   - Name: .linker-options

llvm/test/tools/yaml2obj/ELF/local-symbols.yaml

-# Check we correctly set the sh_info field of .symtab section.
-# A symbol table section's sh_info section header member holds
-# the symbol table index for the first non-local symbol.
+## Check we correctly set the sh_info field of .symtab section.
+## A symbol table section's sh_info section header member holds
+## the symbol table index for the first non-local symbol.
 
 # RUN: yaml2obj -docnum=1 %s -o %t
 # RUN: llvm-readobj --sections %t | FileCheck %s --check-prefix=ONE
 # ONE: Name: .symtab
 # ONE: Info: 2
 
 --- !ELF
 FileHeader:

llvm/test/tools/yaml2obj/ELF/override-shsize.yaml

 ## Check we are able to set custom sh_size field
 ## for different sections.
 
 # RUN: yaml2obj --docnum=1 %s -o %t1
 # RUN: llvm-readelf --sections %t1 | FileCheck %s --check-prefix=CASE1
 
 # CASE1:      Section Headers:
-# CASE1-NEXT:  [Nr] Name           Type     Address          Off    Size  
+# CASE1-NEXT:  [Nr] Name           Type     Address          Off    Size
 # CASE1-NEXT:  [ 0]                NULL     0000000000000000 000000 000000
 # CASE1-NEXT:  [ 1] .dynsym        DYNSYM   0000000000000000 000040 000001
 # CASE1-NEXT:  [ 2] .symtab        SYMTAB   0000000000000000 000058 000002
 # CASE1-NEXT:  [ 3] .dynamic       DYNAMIC  0000000000000000 000070 000003
 # CASE1-NEXT:  [ 4] .rela          RELA     0000000000000000 000070 000004
 # CASE1-NEXT:  [ 5] .nobits        NOBITS   0000000000000000 000070 000005
 # CASE1-NEXT:  [ 6] .group         GROUP    0000000000000000 000070 000006
 # CASE1-NEXT:  [ 7] .gnu.version   VERSYM   0000000000000000 000070 000007

llvm/test/tools/yaml2obj/ELF/program-header-size-offset.yaml

-# Show that yaml2obj properly emits program headers with explicit file size,
-# memory size and offset parameters.
+## Show that yaml2obj properly emits program headers with explicit file size,
+## memory size and offset parameters.
 
 # RUN: yaml2obj %s -o %t
 # RUN: llvm-readobj %t --program-headers | FileCheck %s
 
 # CHECK: ProgramHeaders [
 # CHECK:    Offset: 0x1234
 # CHECK:    FileSize: 1111
 # CHECK:    MemSize: 9999

llvm/test/tools/yaml2obj/ELF/relocation-explicit-symbol-index.yaml

-# Test that a relocation's symbol can be an integer.
-# RUN: yaml2obj %s > %t
-# LLVM tools (both llvm-readobj and llvm-objdump) reject relocations with
-# invalid symbol indexes, so inspect the hex contents instead.
+## Test that a relocation's symbol can be an integer (symbol index).
+
+# RUN: yaml2obj %s -o %t
+## LLVM tools (both llvm-readobj and llvm-objdump) reject relocations with
+## invalid symbol indexes, so inspect the hex contents instead.
 # RUN: llvm-readobj -x .rela.text %t | FileCheck %s
 
 # CHECK:      Hex dump of section '.rela.text':
 # CHECK-NEXT: 0x00000000 00000000 00000000 02000000 42000000
 #                               Symbol index 0x42 --^
 # CHECK-NEXT: 0x00000010 00000000 00000000 00000000 00000000
 # CHECK-NEXT: 0x00000020 02000000 01000000 00000000 00000000
 #             Symbol index 0x01 --^

llvm/test/tools/yaml2obj/ELF/relocation-implicit-symbol-index.yaml

-# This test succeeds but produces an invalid relocation. This test
-# documents this behavoir.
-# RUN: yaml2obj %s > %t
+## If "Symbol" is not specified for a relocation, the symbol index is assumed to be 0.
+
+# RUN: yaml2obj %s -o %t
 # RUN: llvm-readobj -r %t | FileCheck %s
 
+# CHECK:     Relocations [
+# CHECK-NEXT:  Section (2) .rel.text {
+# CHECK-NEXT:    0x1000 R_X86_64_RELATIVE - 0x0
+# CHECK-NEXT:    0x1001 R_X86_64_PC32 - 0x0
+# CHECK-NEXT:  }
+# CHECK-NEXT:]
+
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_EXEC
   Machine:         EM_X86_64
 Sections:
   - Name:            .text
     Type:            SHT_PROGBITS
     Flags:           [ SHF_ALLOC, SHF_EXECINSTR ]
     Content:         "00000000"
   - Name:            .rel.text
     Type:            SHT_REL
     Info:            .text
     Relocations:
       - Offset: 0x1000
+        Type:   R_X86_64_RELATIVE
+      ## R_X86_64_PC32 should have a non-zero symbol index but we don't error.
+      - Offset: 0x1001
         Type:   R_X86_64_PC32
-
-#CHECK:     Relocations [
-#CHECK-NEXT:  Section (2) .rel.text {
-#CHECK-NEXT:    0x1000 R_X86_64_PC32 - 0x0
-#CHECK-NEXT:  }
-#CHECK-NEXT:]

llvm/test/tools/yaml2obj/ELF/section-ordering.yaml

-# Ensures that implicitly added sections can be ordered within Sections.
+## Ensures that implicitly added sections can be ordered within Sections.
+
 # RUN: yaml2obj %s -o %t
 # RUN: llvm-readobj --sections %t | FileCheck %s
 
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_EXEC

llvm/test/tools/yaml2obj/ELF/section-unnamed.yaml

-# Ensure yaml2obj doesn't crash on unnamed sections
+## Check that "Name" defaults to an empty string.
+
 # RUN: yaml2obj %s -o %t
 # RUN: llvm-readobj --sections %t | FileCheck %s
 
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_EXEC

llvm/test/tools/yaml2obj/ELF/sh-addralign.yaml

 ## Check that yaml2obj takes in account section AddressAlign field.
 
-# RUN: yaml2obj %s > %t
+# RUN: yaml2obj %s -o %t
 # RUN: llvm-readobj -S %t | FileCheck %s
 
 # CHECK:      Section {
 # CHECK:        Index:
 # CHECK:        Name: .data
 # CHECK-NEXT:   Type: SHT_PROGBITS
 # CHECK-NEXT:   Flags [
 # CHECK-NEXT:   ]

llvm/test/tools/yaml2obj/ELF/sht-symtab-shndx.yaml

 Sections:
   - Name: bar
     Type: SHT_PROGBITS
 Symbols:
   - Type:  STT_SECTION
     Index: SHN_XINDEX
 
 ## Check that yaml2obj keeps the SHT_SYMTAB_SHNDX section in the output
-## even when symbol's section index value is low enough to not require the extended symtab. 
+## even when symbol's section index value is low enough to not require the extended symtab.
 ## Also, check that symbols in .symtab still have the SHN_XINDEX index.
 
 # RUN: yaml2obj --docnum=2 %s -o %t2
 # RUN: llvm-readobj --sections --symbols --section-data 2>&1 %t2 | FileCheck %s --check-prefix=CASE2
 
 # CASE2:      Section {
 # CASE2:       Name: .symtab_shndx (1)
 # CASE2-NEXT:  Type: SHT_SYMTAB_SHNDX (0x12)

llvm/test/tools/yaml2obj/ELF/symbol-index-invalid.yaml

-# This test insures that the user cannot have both an Index and a Section field.
+## Check that "Index" and "Section" cannot be used together in a symbol.
+
 # RUN: not yaml2obj %s
 
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_EXEC
   Machine:         EM_X86_64

llvm/test/tools/yaml2obj/ELF/symbol-index.yaml

-# RUN: yaml2obj %s > %t
+# RUN: yaml2obj %s -o %t
 # RUN: llvm-readelf -s %t | FileCheck %s
 
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_EXEC
   Machine:         EM_X86_64
 Sections:
   - Name: .text
     Type: SHT_PROGBITS
 Symbols:
   - Name:     absolute1
     Index:    SHN_ABS
     Value:    0x1234
     Binding:  STB_GLOBAL
   - Name:     absolute2
     Index:    0xfff1
     Value:    0x4321
     Binding:  STB_GLOBAL
   - Name:     common1
     Index:    SHN_COMMON
-    Binding:  STB_GLOBAL 
+    Binding:  STB_GLOBAL
   - Name:     common2
     Index:    0xfff2
-    Binding:  STB_GLOBAL 
+    Binding:  STB_GLOBAL
   - Name:     good
     Index:    0x1
     Binding:  STB_GLOBAL
   - Name:     bad
     Index:    0x42
     Binding:  STB_GLOBAL
   - Name:     undef1
     Index:    SHN_UNDEF

llvm/test/tools/yaml2obj/ELF/symbol-type.yaml

-# RUN: yaml2obj %s > %t
+# RUN: yaml2obj %s -o %t
 # RUN: llvm-readobj --symbols %t | FileCheck %s
 
 # CHECK: Name: notype
 # CHECK: Type: None
 # CHECK: Name: normal_type
 # CHECK: Type: Object
 # CHECK: Name: .text
 # CHECK: Type: Section
FileHeader:
   Type:            ET_REL
   Machine:         EM_X86_64
 Sections:
   - Name: .text
     Type: SHT_PROGBITS
 Symbols:
   - Name:    notype
     Type:    STT_NOTYPE
-    Binding: STB_GLOBAL 
+    Binding: STB_GLOBAL
   - Name:    normal_type
     Type:    STT_OBJECT
     Binding: STB_GLOBAL
   - Name:    .text
     Type:    STT_SECTION
     Binding: STB_GLOBAL
   - Name:    known_hex
     Type:    0x1

llvm/test/tools/yaml2obj/ELF/symtab-shinfo.yaml

 # CHECK-NEXT: Flags [
 # CHECK-NEXT:   SHF_ALLOC
 # CHECK-NEXT: ]
 # CHECK-NEXT: Address:
 # CHECK-NEXT: Offset:
 # CHECK-NEXT: Size:
 # CHECK-NEXT: Link:
 # CHECK-NEXT: Info: 26
- 
 --- !ELF
 FileHeader:
   Class:   ELFCLASS64
   Data:    ELFDATA2LSB
   Type:    ET_REL
   Machine: EM_X86_64
 Sections:
   - Name: .symtab

llvm/test/tools/yaml2obj/ELF/verdef-section.yaml

+## Check we are able to handle SHT_GNU_verdef sections.
+
 # RUN: yaml2obj %s -o %t
 # RUN: llvm-readobj -V %t | FileCheck %s
 
-# Check we are able to handle the SHT_GNU_verdef sections.
-
 # CHECK:      VersionDefinitions [
 # CHECK-NEXT:   Definition {
 # CHECK-NEXT:     Version: 1
 # CHECK-NEXT:     Flags: Base
 # CHECK-NEXT:     Index: 1
 # CHECK-NEXT:     Hash: 170240160
 # CHECK-NEXT:     Name: dso.so.0
 # CHECK-NEXT:   }

llvm/test/tools/yaml2obj/ELF/verneed-section.yaml

+## Check we are able to handle SHT_GNU_verneed sections.
+
 # RUN: yaml2obj %s -o %t
 # RUN: llvm-readobj -V %t | FileCheck %s
 
-# Check we are able to handle the SHT_GNU_verneed sections.
-
 # CHECK:      VersionRequirements [
 # CHECK-NEXT:   Dependency {
 # CHECK-NEXT:     Version: 1
 # CHECK-NEXT:     Count: 2
 # CHECK-NEXT:     FileName: dso.so.0
 # CHECK-NEXT:     Entries [
 # CHECK-NEXT:       Entry {
 # CHECK-NEXT:         Hash: 1937

llvm/test/tools/yaml2obj/ELF/versym-section.yaml

- Name:            .gnu.version_r
     Flags:           [ SHF_ALLOC ]
     Address:         0x0000000000200250
     Link:            .dynstr
     AddressAlign:    0x0000000000000004
     Info:            0x0000000000000001
     Dependencies:
       - Version:         1
         File:            dso.so.0
-        Entries:         
+        Entries:
           - Name:            v1
             Hash:            1937
             Flags:           0
             Other:           3
           - Name:            v2
             Hash:            1938
             Flags:           0
             Other:           4

llvm/test/tools/yaml2obj/empty-symbols.yaml

-# Ensure yaml2obj doesn't error on empty optional mappings, such as Symbols
-# RUN: yaml2obj %s -o %t
-
-!ELF
-FileHeader:
-  Class:           ELFCLASS64
-  Data:            ELFDATA2LSB
-  Type:            ET_DYN
-  Machine:         EM_X86_64
-Symbols:

llvm/test/tools/yaml2obj/invalid-output-file.yaml

 # RUN: not yaml2obj -o %p/path/does/not/exist 2>&1 | FileCheck %s
 
-# Don't check the OS-dependent message "No such file or directory".
+## Don't check the OS-dependent message "No such file or directory".
 # CHECK: yaml2obj: error: failed to open '{{.*}}/path/does/not/exist': {{.*}}

llvm/test/tools/yaml2obj/symboless-relocation.yaml

-# Just make sure this isn't an error even though it has no Symbol
-# RUN: yaml2obj %s
-
-!ELF
-FileHeader:
-  Class:           ELFCLASS64
-  Data:            ELFDATA2LSB
-  Type:            ET_EXEC
-  Machine:         EM_X86_64
-Sections:
-  - Name:            .text
-    Type:            SHT_PROGBITS
-    Flags:           [ SHF_ALLOC, SHF_EXECINSTR ]
-    Content:         "00000000"
-  - Name:            .rel.text
-    Type:            SHT_REL
-    Info:            .text
-    Relocations:
-      - Offset: 0x1000
-        Type:   R_X86_64_RELATIVE