This is an archive of the discontinued LLVM Phabricator instance.

Fix error message missed in commit dde589389fcb8b5098f7a47f1b781b27d29a0cac.
ClosedPublic

Authored by browneee on Nov 13 2019, 11:25 AM.

Event Timeline

browneee created this revision.Nov 13 2019, 11:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 13 2019, 11:25 AM

Thanks for fixing this and for the cleanup. Since we will have the same const INDEX_VERSION variable defined in both the bitcode reader and writer, I'm thinking it will make sense to move this somewhere common, which I guess would be ModuleSummaryIndex.h, maybe as a static variable in the ModuleSummaryIndex class itself.

browneee updated this revision to Diff 229665.Nov 15 2019, 4:32 PM

Moved constant to ModuleSummaryIndex as suggested. Now shared between BitcodeReader.cpp and BitcodeWriter.cpp.

tejohnson accepted this revision.Nov 15 2019, 8:24 PM

lgtm, thanks

This revision is now accepted and ready to land.Nov 15 2019, 8:24 PM

I am not a committer, please submit for me.

This revision was automatically updated to reflect the committed changes.