Page MenuHomePhabricator

Use nofree argument attributr hor heap-to-stack conversion
ClosedPublic

Authored by sstefan1 on Tue, Nov 12, 12:50 PM.

Details

Summary

Use nofree argument attribute for heap-to-stack conversion.

Diff Detail

Event Timeline

sstefan1 created this revision.Tue, Nov 12, 12:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Nov 12, 12:50 PM
jdoerfert accepted this revision.Tue, Nov 12, 5:38 PM

LGTM, one nit.

llvm/lib/Transforms/IPO/Attributor.cpp
4159

NOTE can be removed as well, I think.

This revision is now accepted and ready to land.Tue, Nov 12, 5:38 PM
arsenm added a subscriber: arsenm.Tue, Nov 12, 8:41 PM

Typo hor in commit message

Typo hor in commit message

Two typos even. Thanks for noticing!

sstefan1 marked an inline comment as done.Wed, Nov 13, 8:55 AM

Typo hor in commit message

Two typos even. Thanks for noticing!

Thanks! Will double check before I commit

llvm/lib/Transforms/IPO/Attributor.cpp
4159

I'll remove it before I commit.

This revision was automatically updated to reflect the committed changes.