This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Fix bug introduced in 47a5c36b37f0
ClosedPublic

Authored by dfukalov on Nov 6 2019, 11:07 AM.

Details

Summary

[AMDGPU] Fix bug introduced in 47a5c36b37f0

Event Timeline

dfukalov created this revision.Nov 6 2019, 11:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2019, 11:07 AM
arsenm added inline comments.Nov 6 2019, 11:08 AM
llvm/test/Analysis/CostModel/AMDGPU/shufflevector.ll
55

Should still be checking the returned cost

dfukalov edited the summary of this revision. (Show Details)Nov 6 2019, 11:11 AM
dfukalov updated this revision to Diff 228113.Nov 6 2019, 11:38 AM

Address comment

dfukalov marked an inline comment as done.Nov 6 2019, 11:38 AM
arsenm added inline comments.Nov 6 2019, 11:45 AM
llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
741

I don't see how this works? Shouldn't this be returning instead of falling through?

dfukalov marked 2 inline comments as done.Nov 6 2019, 12:07 PM
dfukalov added inline comments.
llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
741

You're right, thanks!

arsenm accepted this revision.Nov 6 2019, 12:12 PM

LGTM

This revision is now accepted and ready to land.Nov 6 2019, 12:12 PM
arsenm added a comment.Nov 6 2019, 4:14 PM

Commit message could uses work though, include revision in the long description, not the first line

This revision was automatically updated to reflect the committed changes.
dfukalov marked an inline comment as done.