This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Remove allow-deprecated-dag-overlap and fix broken tests
ClosedPublic

Authored by jsji on Nov 1 2019, 1:08 PM.

Details

Summary

This is found during review of https://reviews.llvm.org/D67088.

CHECK-DAG is non-overlapping after https://reviews.llvm.org/D47106.
-allow-deprecated-dag-overlap was introduced to temporary accept old
behavior.

But it actually hide some broken tests, eg: test/CodeGen/PowerPC/swaps-le-1.ll
The codegen has changed, but the CHECK-DAG still PASS due to allowing overlap.

This patch remove the deprecated options, and fix the broken tests.

Event Timeline

jsji created this revision.Nov 1 2019, 1:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2019, 1:08 PM

@shchenz Can you have a look? Since this should be committed before your https://reviews.llvm.org/D67088. Thanks.

shchenz accepted this revision as: shchenz.Nov 11 2019, 9:30 PM

LGTM.

Thanks for cleaning this up.

This revision is now accepted and ready to land.Nov 11 2019, 9:30 PM
This revision was automatically updated to reflect the committed changes.