This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Remove SVN support from VersionFromVCS.cmake
ClosedPublic

Authored by tstellar on Oct 31 2019, 1:42 PM.

Event Timeline

tstellar created this revision.Oct 31 2019, 1:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2019, 1:42 PM
Herald added a subscriber: mgorny. · View Herald Transcript
phosek accepted this revision.Oct 31 2019, 2:56 PM

LGTM

llvm/cmake/modules/VersionFromVCS.cmake
51

This function just forwards to get_source_info_git now, so we could just delete it and rename get_source_info_git to get_source_info?

This revision is now accepted and ready to land.Oct 31 2019, 2:56 PM
tstellar marked an inline comment as done.Oct 31 2019, 3:34 PM
tstellar added inline comments.
llvm/cmake/modules/VersionFromVCS.cmake
51

Ok, I'll do this before I commt.

tstellar updated this revision to Diff 227370.Oct 31 2019, 4:22 PM

Rename get_source_info_git to get_source_info.

This revision was automatically updated to reflect the committed changes.