Page MenuHomePhabricator

AsmParser: Allow FMF on varargs call
AcceptedPublic

Authored by tpr on Oct 29 2019, 5:01 AM.

Details

Summary

D14707 added code to allow FMF on a call with a float or vector of float
return type. But it accidentally disallowed it when using (...) syntax
for a varargs call. This commit fixes that.

Event Timeline

tpr created this revision.Oct 29 2019, 5:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2019, 5:01 AM
tpr added a subscriber: foad.
spatel added a reviewer: foad.Oct 29 2019, 9:16 AM

Does D69161 cover this change? If so, we could add the test there and fix the problem in 1 step.

foad added a comment.Oct 29 2019, 9:40 AM

Does D69161 cover this change? If so, we could add the test there and fix the problem in 1 step.

I think this bug fix is orthogonal to D69161, which adds new functionality.

tpr added a comment.Oct 29 2019, 9:59 AM

Does D69161 cover this change? If so, we could add the test there and fix the problem in 1 step.

I think this bug fix is orthogonal to D69161, which adds new functionality.

The way you have changed the call check to !isa<FPMathOperator>(CI) means you might have accidentally fixed my bug anyway. I'll check later.

foad accepted this revision.Nov 6 2019, 3:22 AM
In D69557#1725616, @tpr wrote:

Does D69161 cover this change? If so, we could add the test there and fix the problem in 1 step.

I think this bug fix is orthogonal to D69161, which adds new functionality.

The way you have changed the call check to !isa<FPMathOperator>(CI) means you might have accidentally fixed my bug anyway. I'll check later.

You're right, I have accidentally fixed your bug. It would still be good to commit your test case, which LGTM.

This revision is now accepted and ready to land.Nov 6 2019, 3:22 AM