Attributor: Move list of opcodes

[arsenm]

Summary

This is reusable between different attributes.

[jdoerfert]

I think this (list/call) needs to be either replaced Attributor::checkForAllCallLikeInstructions, replace the list there, or placed at the same level.

[arsenm]

Rebase. checkForAllCallLikeInstructions seems to have a subset for some reason

[jdoerfert]

In D69496#3929714, @arsenm wrote:

Rebase. checkForAllCallLikeInstructions seems to have a subset for some reason

That's probably bad, I assume. We might want to change it there to the full list and delete the Opcodes here.

[arsenm]

In D69496#3931002, @jdoerfert wrote:

In D69496#3929714, @arsenm wrote:

Rebase. checkForAllCallLikeInstructions seems to have a subset for some reason

That's probably bad, I assume. We might want to change it there to the full list and delete the Opcodes here.

I guess it depends what "call like" means. I looked at the exception instructions and they seem to not have a call target operand

llvm/lib/Transforms/IPO/AttributorAttributes.cpp

 static cl::opt<unsigned> MaxInterferingAccesses(
     "attributor-max-interfering-accesses", cl::Hidden,
     cl::desc("Maximum number of interfering accesses to "
              "check before assuming all might interfere."),
     cl::init(6));
 
 STATISTIC(NumAAs, "Number of abstract attributes created");
 
+
+static const unsigned CallLikeOpcodes[] = {
+  Instruction::Call, Instruction::Invoke,
+  Instruction::CatchSwitch, Instruction::Resume,
+  Instruction::CleanupRet, Instruction::CallBr
+};
+
 // Some helper macros to deal with statistics tracking.
 //
 // Usage:
 // For simple IR attribute tracking overload trackStatistics in the abstract
 // attribute and choose the right STATS_DECLTRACK_********* macro,
 // e.g.,:
 //  void trackStatistics() const override {
 //    STATS_DECLTRACK_ARG_ATTR(returned)
auto CheckForNoUnwind = [&](Instruction &I) {
         const auto &NoUnwindAA = A.getAAFor<AANoUnwind>(
             *this, IRPosition::callsite_function(*CB), DepClassTy::REQUIRED);
         return NoUnwindAA.isAssumedNoUnwind();
       }
       return false;
     };
 
     bool UsedAssumedInformation = false;
-    if (!A.checkForAllInstructions(CheckForNoUnwind, *this, Opcodes,
+    if (!A.checkForAllInstructions(CheckForNoUnwind, *this, CallLikeOpcodes,
                                    UsedAssumedInformation))
       return indicatePessimisticFixpoint();
 
     return ChangeStatus::UNCHANGED;
   }
 };
 
 struct AANoUnwindFunction final : public AANoUnwindImpl {