This is an archive of the discontinued LLVM Phabricator instance.

Differential D69375

[NFC] Remove redundant lines
ClosedPublic

Authored by dfukalov on Oct 24 2019, 4:52 AM.

Details

Reviewers
rampitec
Commits
rG6d0fc4373e9f: [NFC] Remove redundant lines

Diff Detail

Event Timeline

dfukalov created this revision.Oct 24 2019, 4:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 24 2019, 4:52 AM
Herald added subscribers: hiraditya, nhaehnle, jvesely, arsenm. · View Herald Transcript
Harbormaster completed remote builds in B39985: Diff 226226.Oct 24 2019, 4:53 AM
rampitec accepted this revision.Oct 24 2019, 8:17 AM

LGTM

This revision is now accepted and ready to land.Oct 24 2019, 8:17 AM
Closed by commit rG6d0fc4373e9f: [NFC] Remove redundant lines (authored by dfukalov). · Explain WhyOct 24 2019, 9:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
4 lines

Diff 226226

llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp

Show First 20 Lines • Show All 1,161 Lines • ▼ Show 20 Linesbool AMDGPULibCalls::fold_rootn(CallInst *CI, IRBuilder<> &B,
} }
int ci_opr1 = (int)CINT->getSExtValue(); int ci_opr1 = (int)CINT->getSExtValue();
if (ci_opr1 == 1) { // rootn(x, 1) = x if (ci_opr1 == 1) { // rootn(x, 1) = x
LLVM_DEBUG(errs() << "AMDIC: " << *CI << " ---> " << *opr0 << "\n"); LLVM_DEBUG(errs() << "AMDIC: " << *CI << " ---> " << *opr0 << "\n");
replaceCall(opr0); replaceCall(opr0);
return true; return true;
} }
if (ci_opr1 == 2) { // rootn(x, 2) = sqrt(x) if (ci_opr1 == 2) { // rootn(x, 2) = sqrt(x)
std::vector<const Type*> ParamsTys;
ParamsTys.push_back(opr0->getType());
Module *M = CI->getModule(); Module *M = CI->getModule();
if (FunctionCallee FPExpr = if (FunctionCallee FPExpr =
getFunction(M, AMDGPULibFunc(AMDGPULibFunc::EI_SQRT, FInfo))) { getFunction(M, AMDGPULibFunc(AMDGPULibFunc::EI_SQRT, FInfo))) {
LLVM_DEBUG(errs() << "AMDIC: " << *CI << " ---> sqrt(" << *opr0 << ")\n"); LLVM_DEBUG(errs() << "AMDIC: " << *CI << " ---> sqrt(" << *opr0 << ")\n");
Value *nval = CreateCallEx(B,FPExpr, opr0, "__rootn2sqrt"); Value *nval = CreateCallEx(B,FPExpr, opr0, "__rootn2sqrt");
replaceCall(nval); replaceCall(nval);
return true; return true;
} }
Show All 9 Linesbool AMDGPULibCalls::fold_rootn(CallInst *CI, IRBuilder<> &B,
} else if (ci_opr1 == -1) { // rootn(x, -1) = 1.0/x } else if (ci_opr1 == -1) { // rootn(x, -1) = 1.0/x
LLVM_DEBUG(errs() << "AMDIC: " << *CI << " ---> 1.0 / " << *opr0 << "\n"); LLVM_DEBUG(errs() << "AMDIC: " << *CI << " ---> 1.0 / " << *opr0 << "\n");
Value *nval = B.CreateFDiv(ConstantFP::get(opr0->getType(), 1.0), Value *nval = B.CreateFDiv(ConstantFP::get(opr0->getType(), 1.0),
opr0, opr0,
"__rootn2div"); "__rootn2div");
replaceCall(nval); replaceCall(nval);
return true; return true;
} else if (ci_opr1 == -2) { // rootn(x, -2) = rsqrt(x) } else if (ci_opr1 == -2) { // rootn(x, -2) = rsqrt(x)
std::vector<const Type*> ParamsTys;
ParamsTys.push_back(opr0->getType());
Module *M = CI->getModule(); Module *M = CI->getModule();
if (FunctionCallee FPExpr = if (FunctionCallee FPExpr =
getFunction(M, AMDGPULibFunc(AMDGPULibFunc::EI_RSQRT, FInfo))) { getFunction(M, AMDGPULibFunc(AMDGPULibFunc::EI_RSQRT, FInfo))) {
LLVM_DEBUG(errs() << "AMDIC: " << *CI << " ---> rsqrt(" << *opr0 LLVM_DEBUG(errs() << "AMDIC: " << *CI << " ---> rsqrt(" << *opr0
<< ")\n"); << ")\n");
Value *nval = CreateCallEx(B,FPExpr, opr0, "__rootn2rsqrt"); Value *nval = CreateCallEx(B,FPExpr, opr0, "__rootn2rsqrt");
replaceCall(nval); replaceCall(nval);
return true; return true;
▲ Show 20 Lines • Show All 594 Lines • Show Last 20 Lines