[clangd] Propogate context in TUScheduler::run

[sammccall]

Can you modify TEST_F(TUSchedulerTests, Run) to verify?

[sammccall]

Oops, this doesn't actually work - you're not setting the cloned context anywhere...

[merge_guards_bot]

Build result: fail - 59544 tests passed, 1 failed and 805 were skipped.

failed: LLVM.tools/llvm-ar/mri-utf8.test

Log files: cmake-log.txt, ninja_check_all-log.txt, CMakeCache.txt

[kadircet]

• Add tests

[kadircet]

In D69328#1718509, @sammccall wrote:

Oops, this doesn't actually work - you're not setting the cloned context anywhere...

I am moving it into the lambda, which should extend the lifespan of context until destruction of it. Why would I need to set it in addition to that?

[ilya-biryukov]

clang-tools-extra/clangd/TUScheduler.cpp

925

Maybe inline ActionWithCtx? This should look fine as the last argument of the function call.

[sammccall]

In D69328#1718549, @kadircet wrote:

In D69328#1718509, @sammccall wrote:

Oops, this doesn't actually work - you're not setting the cloned context anywhere...

I am moving it into the lambda, which should extend the lifespan of context until destruction of it. Why would I need to set it in addition to that?

Because we don't just want the context to be alive, it should be the context associated with the current thread.
e.g. if a new span is created, it should be nested within the other context.

[merge_guards_bot]

Build result: fail - 59544 tests passed, 1 failed and 805 were skipped.

failed: LLVM.tools/llvm-ar/mri-utf8.test

Log files: cmake-log.txt, ninja_check_all-log.txt, CMakeCache.txt

[kadircet]

• Address comments

[merge_guards_bot]

Build result: fail - 59544 tests passed, 1 failed and 805 were skipped.

failed: LLVM.tools/llvm-ar/mri-utf8.test

Log files: cmake-log.txt, ninja_check_all-log.txt, CMakeCache.txt

clang-tools-extra/clangd/TUScheduler.cpp

 // - If subsequent updates come before rebuild was started, we replace the
 //   pending inputs and reset the timer.
 // - If any reads of the AST are scheduled, we start building the AST
 //   immediately.
 
 #include "TUScheduler.h"
 #include "Cancellation.h"
 #include "Compiler.h"
+#include "Context.h"
 #include "Diagnostics.h"
 #include "GlobalCompilationDatabase.h"
 #include "Logger.h"
 #include "ParsedAST.h"
 #include "Preamble.h"
 #include "Trace.h"
 #include "index/CanonicalIncludes.h"
 #include "clang/Frontend/CompilerInvocation.h"
llvm::StringRef TUScheduler::getContents(PathRef File) const {
   }
   return It->second->Contents;
 }
 
 void TUScheduler::run(llvm::StringRef Name,
                       llvm::unique_function<void()> Action) {
   if (!PreambleTasks)
     return Action();
-  PreambleTasks->runAsync(Name, std::move(Action));
+  PreambleTasks->runAsync(Name, [Ctx = Context::current().clone(),
+                                 Action = std::move(Action)]() mutable {
+    WithContext WC(std::move(Ctx));
+    Action();
+  });
 }
 
 void TUScheduler::runWithAST(
     llvm::StringRef Name, PathRef File,
     llvm::unique_function<void(llvm::Expected<InputsAndAST>)> Action) {
   auto It = Files.find(File);
   if (It == Files.end()) {
     Action(llvm::make_error<LSPError>(

clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp

TUScheduler S(CDB, /*AsyncThreadsCount=*/getDefaultAsyncThreadsCount(),
                 /*StorePreambleInMemory=*/true, /*ASTCallbacks=*/nullptr,
                 /*UpdateDebounce=*/std::chrono::steady_clock::duration::zero(),
                 ASTRetentionPolicy());
   std::atomic<int> Counter(0);
   S.run("add 1", [&] { ++Counter; });
   S.run("add 2", [&] { Counter += 2; });
   ASSERT_TRUE(S.blockUntilIdle(timeoutSeconds(10)));
   EXPECT_EQ(Counter.load(), 3);
+
+  Notification TaskRun;
+  Key<int> TestKey;
+  WithContextValue CtxWithKey(TestKey, 10);
+  S.run("props context", [&] {
+    EXPECT_EQ(Context::current().getExisting(TestKey), 10);
+    TaskRun.notify();
+  });
+  TaskRun.wait();
 }
 
 TEST_F(TUSchedulerTests, TUStatus) {
   class CaptureTUStatus : public DiagnosticsConsumer {
   public:
     void onDiagnosticsReady(PathRef File,
                             std::vector<Diag> Diagnostics) override {}