This is an archive of the discontinued LLVM Phabricator instance.

Prune Pass.h include from DataLayout.h. NFCI
ClosedPublic

Authored by bjope on Oct 21 2019, 7:51 AM.

Details

Summary

Reduce include dependencies by no longer including Pass.h from
DataLayout.h. That include seemed irrelevant to DataLayout, as
wee as lots of users of DataLayout.

Diff Detail

Event Timeline

bjope created this revision.Oct 21 2019, 7:51 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 21 2019, 7:51 AM
rnk accepted this revision.Oct 21 2019, 9:58 AM

That include seemed irrelevant to DataLayout, as
wee as lots of users of DataLayout.

Typo in commit message (well as...), worth fixing before landing.

lgtm

llvm/include/llvm/IR/DataLayout.h
622–623

I guess this is the main reason for the Type.h include.

This revision is now accepted and ready to land.Oct 21 2019, 9:58 AM
This revision was automatically updated to reflect the committed changes.