Page MenuHomePhabricator

Refactor DependencyScanningTool to its own file
ClosedPublic

Authored by kousikk on Fri, Oct 18, 11:02 AM.

Details

Summary

There's no behavior change - just moving DependencyScanningTool to its own file
since this tool can be reused across both clang-scan-deps binary and an interface
exposed as part of libClang APIs.

Diff Detail

Event Timeline

kousikk created this revision.Fri, Oct 18, 11:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Oct 18, 11:02 AM
kousikk updated this revision to Diff 225667.Fri, Oct 18, 11:05 AM

Lint fixes

Harbormaster completed remote builds in B39798: Diff 225667.
Bigcheese accepted this revision.Mon, Oct 21, 5:30 PM

LGTM with style nit. I like that this decouples DependencyScanningTool from printing the results.

clang/tools/clang-scan-deps/ClangScanDeps.cpp
105–107

This looks like it needs to be clang-formatted.

This revision is now accepted and ready to land.Mon, Oct 21, 5:30 PM
kousikk updated this revision to Diff 225994.Mon, Oct 21, 9:53 PM

Run clang format

kousikk marked an inline comment as done.Mon, Oct 21, 9:53 PM
This revision was automatically updated to reflect the committed changes.