Page MenuHomePhabricator

kousikk (Kousik Kumar)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2019, 10:42 AM (9 w, 6 d)

Recent Activity

Mon, Sep 16

kousikk updated the summary of D67635: Fix for stringized function-macro args continued across lines.
Mon, Sep 16, 4:42 PM · Restricted Project
kousikk updated the summary of D67635: Fix for stringized function-macro args continued across lines.
Mon, Sep 16, 4:42 PM · Restricted Project
kousikk created D67635: Fix for stringized function-macro args continued across lines.
Mon, Sep 16, 2:26 PM · Restricted Project

Fri, Sep 13

kousikk added a comment to D67091: Fix for headers having the same name as a directory.

I don't have commit access - do you mind submitting this for me? Thanks!

Fri, Sep 13, 12:55 PM · Restricted Project, Restricted Project

Thu, Sep 12

kousikk added a comment to D67091: Fix for headers having the same name as a directory.

I was unable to reproduce the failures when I moved the check to createFile. What kind of failures did you see? Did you move it right to the start of the function? I would recommend rebasing the patch and retrying.

I saw an assertion error - but I realize now that it was because it was not at the top of the function. I had put it after Entry->getContents() which was throwing an assertion. I now realize that for getContents() to work, the entry needs to be a file. Thanks for correcting me!

Thu, Sep 12, 12:42 PM · Restricted Project, Restricted Project
kousikk updated the diff for D67091: Fix for headers having the same name as a directory.
  • Add validation inside the createFile() function
Thu, Sep 12, 12:42 PM · Restricted Project, Restricted Project
kousikk updated the diff for D67091: Fix for headers having the same name as a directory.
  • Add validation inside the createFile() function
Thu, Sep 12, 12:41 PM · Restricted Project, Restricted Project
kousikk added a comment to D67091: Fix for headers having the same name as a directory.

Sorry about the delay on this - I was OOO (back now).

Thu, Sep 12, 7:45 AM · Restricted Project, Restricted Project
kousikk updated the diff for D67091: Fix for headers having the same name as a directory.
  • Add validation inside the createFile() function
Thu, Sep 12, 7:43 AM · Restricted Project, Restricted Project
kousikk updated the diff for D67091: Fix for headers having the same name as a directory.
  • Add tests and remove the fix inside createFile since it fails in other cases
Thu, Sep 12, 7:42 AM · Restricted Project, Restricted Project
kousikk updated the diff for D67091: Fix for headers having the same name as a directory.
  • Add validation inside the createFile() function
Thu, Sep 12, 5:17 AM · Restricted Project, Restricted Project
kousikk updated the diff for D67091: Fix for headers having the same name as a directory.
  • Add validation inside the createFile() function
Thu, Sep 12, 5:17 AM · Restricted Project, Restricted Project

Tue, Sep 3

kousikk added a comment to D67091: Fix for headers having the same name as a directory.

Sure I'll add a test case!

Tue, Sep 3, 7:45 PM · Restricted Project, Restricted Project
kousikk created D67091: Fix for headers having the same name as a directory.
Tue, Sep 3, 3:50 AM · Restricted Project, Restricted Project

Jul 10 2019

Herald updated subscribers of D53354: [WIP][NOT FOR COMMIT][PROTOTYPE] clang-scan-deps: dependency scanning tool rough prototype.
Jul 10 2019, 1:59 PM · Restricted Project