Also changes the wasm YAML format to reflect the possibility of having
multiple return types and to put the returns after the params for
consistency with the binary encoding.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/CodeGen/WebAssembly/multivalue.ll | ||
---|---|---|
11 | Unrelated question to this CL: Do we treat pair and packed pair in the same way? |
Great!
llvm/lib/Object/WasmObjectFile.cpp | ||
---|---|---|
887 | Do we want to error out somehow if the feature flags of the object file don't include multi-value? |
llvm/lib/Object/WasmObjectFile.cpp | ||
---|---|---|
887 | That's an interesting idea! I don't think we have a precedent for that kind of validation in the object file parser. It would also be somewhat intrusive, since the target features section is one of the last sections to be parsed, so there would have to be a separate step at the end where feature invariants are checked. The invariants we could check in such a step would also be limited since individual instructions are not exposed in the object file abstraction. | |
llvm/test/CodeGen/WebAssembly/multivalue.ll | ||
11 | Hmm, I guess this isn't a great test because there wouldn't be any padding in this struct anyway, so in this case it literally is the same. I'm not sure what would happen with a packed struct that should contain padding. I'll add a better test in a follow up CL. |
Do we want to error out somehow if the feature flags of the object file don't include multi-value?