This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Do not combine dpp with physreg def
ClosedPublic

Authored by rampitec on Oct 16 2019, 11:31 AM.

Diff Detail

Event Timeline

rampitec created this revision.Oct 16 2019, 11:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 16 2019, 11:31 AM
arsenm accepted this revision.Oct 16 2019, 11:36 AM

LGTM

llvm/test/CodeGen/AMDGPU/dpp_combine.mir
578

Should also add a test with a read of a physreg since that won't work either

This revision is now accepted and ready to land.Oct 16 2019, 11:36 AM
rampitec marked an inline comment as done.Oct 16 2019, 11:46 AM
rampitec added inline comments.
llvm/test/CodeGen/AMDGPU/dpp_combine.mir
578

Right. It still does not work. I will do a separate change.

This revision was automatically updated to reflect the committed changes.