Select vector G_ADD for MIPS32 with MSA. We have to set bank
for vector operands to fprb and selectImpl will do the rest.
builtin_msa_addv_<format> will be transformed into G_ADD
in legalizeIntrinsic and selected in the same way.
builtin_msa_addvi_<format> will be directly selected into
ADDVI_<format> in legalizeIntrinsic. MIR tests for it have
unnecessary additional copies. Capture current state of tests
with run-pass=legalizer with a test in test/CodeGen/MIR/Mips.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
lib/Target/Mips/MipsLegalizerInfo.cpp | ||
---|---|---|
44 ↗ | (On Diff #225180) | Are there any advantages of passing the T as a template parameter instead of a regular function argument with more mnemonic name? |
48 ↗ | (On Diff #225180) | It can be written a bit shorter: if (Val == Query.Types[T]) return true; |
55 ↗ | (On Diff #225180) | Do you use this class anywhere? |
lib/Target/Mips/MipsLegalizerInfo.cpp | ||
---|---|---|
44 ↗ | (On Diff #225180) | Not that I am aware of. Then change it to: |
55 ↗ | (On Diff #225180) | Missed that, it was meant to be used later for scalarize, will remove it for now. |
Comment Actions
LGTM
lib/Target/Mips/MipsLegalizerInfo.cpp | ||
---|---|---|
44 ↗ | (On Diff #225180) |
Yes. |
Comment Actions
Will wait for conclusion of D68946 before commit, to see what to do with mir tests for legalizer.