Page MenuHomePhabricator

Remove unnecessary codes in llvm-dwarfdump
Needs ReviewPublic

Authored by duongnhn on Oct 11 2019, 1:24 PM.

Details

Summary

These codes is not needed.
Remove them can reduce the size in x64 window build from ~14MB to ~3MB.

Diff Detail

Event Timeline

duongnhn created this revision.Oct 11 2019, 1:24 PM
duongnhn edited reviewers, added: bkramer, jakehehrlich; removed: MaskRay.Oct 11 2019, 1:38 PM

I'm not sure why I was added but this looks fine to me. If it compiles and runs on everyone's system I can't see how this could be anything but good.

I'm not sure why I was added but this looks fine to me. If it compiles and runs on everyone's system I can't see how this could be anything but good.

Sorry, I'm not able to find the exact owner for this so I thought you might be related.

rupprecht added a subscriber: rupprecht.

Does check-all pass with this change? I'd imagine these are necessary to print target-specific information.

Does check-all pass with this change? I'd imagine these are necessary to print target-specific information.

You are right --all options is not working properly with this. I will delete this.

JDevlieghere resigned from this revision.Thu, Oct 31, 9:10 AM