This is an archive of the discontinued LLVM Phabricator instance.

[Alignment] Migrate Attribute::getWith(Stack)Alignment
ClosedPublic

Authored by gchatelet on Oct 10 2019, 8:20 AM.

Event Timeline

gchatelet created this revision.Oct 10 2019, 8:20 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript

@courbet there's a slight difference in the way the field is serialized in the mir / ir format (hence not [NFC]) but there's no change in semantics.

courbet accepted this revision.Oct 15 2019, 5:05 AM
courbet added inline comments.
llvm/lib/IR/Core.cpp
2792

Align

llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
4168

const

llvm/lib/Target/AMDGPU/AMDGPULowerKernelArguments.cpp
78

Align

131–132

ditto

llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
506

const

524

const

This revision is now accepted and ready to land.Oct 15 2019, 5:05 AM
gchatelet updated this revision to Diff 225006.Oct 15 2019, 5:23 AM
  • Address comments
gchatelet updated this revision to Diff 225010.Oct 15 2019, 5:33 AM
  • Fix naming collision
This revision was automatically updated to reflect the committed changes.