This is an archive of the discontinued LLVM Phabricator instance.

Differential D68608

[clang] Accept -ftrivial-auto-var-init in clang-cl
ClosedPublic

Authored by vitalybuka on Oct 7 2019, 4:40 PM.

Details

Reviewers
eugenis
rnk
Commits
rG4fde20f4e412: [clang] Accept -ftrivial-auto-var-init in clang-cl
rL373992: [clang] Accept -ftrivial-auto-var-init in clang-cl
rC373992: [clang] Accept -ftrivial-auto-var-init in clang-cl

Diff Detail

Event Timeline

vitalybuka created this revision.Oct 7 2019, 4:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2019, 4:40 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rnk accepted this revision.Oct 7 2019, 4:42 PM

lgtm

clang/include/clang/Driver/Options.td
1720

Should this really be Joined? Does it take an argument? Should it use Flag?

This revision is now accepted and ready to land.Oct 7 2019, 4:42 PM
vitalybuka marked an inline comment as done.Oct 7 2019, 4:55 PM
vitalybuka added inline comments.
clang/include/clang/Driver/Options.td
1720

D68610

Harbormaster completed remote builds in B39125: Diff 223694.Oct 7 2019, 10:06 PM
Closed by commit rL373992: [clang] Accept -ftrivial-auto-var-init in clang-cl (authored by vitalybuka). · Explain WhyOct 7 2019, 10:24 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2019, 10:24 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
include/
clang/
Driver/
4 lines
test/
Driver/
2 lines

Diff 223694

clang/include/clang/Driver/Options.td

Show First 20 Lines • Show All 1,709 Lines • ▼ Show 20 Lines HelpText<"Enable stack protectors for some functions vulnerable to stack smashing. "
"as well as any calls to alloca or the taking of an address from a local variable">; "as well as any calls to alloca or the taking of an address from a local variable">;
def fstack_protector : Flag<["-"], "fstack-protector">, Group<f_Group>, def fstack_protector : Flag<["-"], "fstack-protector">, Group<f_Group>,
HelpText<"Enable stack protectors for some functions vulnerable to stack smashing. " HelpText<"Enable stack protectors for some functions vulnerable to stack smashing. "
"This uses a loose heuristic which considers functions vulnerable " "This uses a loose heuristic which considers functions vulnerable "
"if they contain a char (or 8bit integer) array or constant sized calls to " "if they contain a char (or 8bit integer) array or constant sized calls to "
"alloca, which are of greater size than ssp-buffer-size (default: 8 bytes). " "alloca, which are of greater size than ssp-buffer-size (default: 8 bytes). "
"All variable sized calls to alloca are considered vulnerable">; "All variable sized calls to alloca are considered vulnerable">;
def ftrivial_auto_var_init : Joined<["-"], "ftrivial-auto-var-init=">, Group<f_Group>, def ftrivial_auto_var_init : Joined<["-"], "ftrivial-auto-var-init=">, Group<f_Group>,
Flags<[CC1Option]>, HelpText<"Initialize trivial automatic stack variables: uninitialized (default)" Flags<[CC1Option, CoreOption]>, HelpText<"Initialize trivial automatic stack variables: uninitialized (default)"
" | pattern">, Values<"uninitialized,pattern">; " | pattern">, Values<"uninitialized,pattern">;
def enable_trivial_var_init_zero : Joined<["-"], "enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang">, def enable_trivial_var_init_zero : Joined<["-"], "enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang">,
rnkUnsubmitted
Not Done
ReplyInline Actions

Should this really be Joined? Does it take an argument? Should it use Flag?

rnk: Should this really be Joined? Does it take an argument? Should it use Flag?
vitalybukaAuthorUnsubmitted
Done
ReplyInline Actions

D68610

vitalybuka: D68610
Flags<[CC1Option]>, Flags<[CC1Option, CoreOption]>,
HelpText<"Trivial automatic variable initialization to zero is only here for benchmarks, it'll eventually be removed, and I'm OK with that because I'm only using it to benchmark">; HelpText<"Trivial automatic variable initialization to zero is only here for benchmarks, it'll eventually be removed, and I'm OK with that because I'm only using it to benchmark">;
def fstandalone_debug : Flag<["-"], "fstandalone-debug">, Group<f_Group>, Flags<[CoreOption]>, def fstandalone_debug : Flag<["-"], "fstandalone-debug">, Group<f_Group>, Flags<[CoreOption]>,
HelpText<"Emit full debug info for all types used by the program">; HelpText<"Emit full debug info for all types used by the program">;
def fno_standalone_debug : Flag<["-"], "fno-standalone-debug">, Group<f_Group>, Flags<[CoreOption]>, def fno_standalone_debug : Flag<["-"], "fno-standalone-debug">, Group<f_Group>, Flags<[CoreOption]>,
HelpText<"Limit debug information produced to reduce size of debug binary">; HelpText<"Limit debug information produced to reduce size of debug binary">;
def flimit_debug_info : Flag<["-"], "flimit-debug-info">, Flags<[CoreOption]>, Alias<fno_standalone_debug>; def flimit_debug_info : Flag<["-"], "flimit-debug-info">, Flags<[CoreOption]>, Alias<fno_standalone_debug>;
def fno_limit_debug_info : Flag<["-"], "fno-limit-debug-info">, Flags<[CoreOption]>, Alias<fstandalone_debug>; def fno_limit_debug_info : Flag<["-"], "fno-limit-debug-info">, Flags<[CoreOption]>, Alias<fstandalone_debug>;
def fdebug_macro : Flag<["-"], "fdebug-macro">, Group<f_Group>, Flags<[CoreOption]>, def fdebug_macro : Flag<["-"], "fdebug-macro">, Group<f_Group>, Flags<[CoreOption]>,
▲ Show 20 Lines • Show All 1,553 Lines • Show Last 20 Lines

clang/test/Driver/cl-options.c

Show First 20 Lines • Show All 647 Lines • ▼ Show 20 Lines
// RUN: -fprofile-generate \ // RUN: -fprofile-generate \
// RUN: -fprofile-generate=dir \ // RUN: -fprofile-generate=dir \
// RUN: -fno-profile-generate \ // RUN: -fno-profile-generate \
// RUN: -fno-profile-instr-generate \ // RUN: -fno-profile-instr-generate \
// RUN: -fno-profile-instr-use \ // RUN: -fno-profile-instr-use \
// RUN: -fcs-profile-generate \ // RUN: -fcs-profile-generate \
// RUN: -fcs-profile-generate=dir \ // RUN: -fcs-profile-generate=dir \
// RUN: -ftime-trace \ // RUN: -ftime-trace \
// RUN: -ftrivial-auto-var-init=zero \
// RUN: -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang \
// RUN: --version \ // RUN: --version \
// RUN: -Werror /Zs -- %s 2>&1 // RUN: -Werror /Zs -- %s 2>&1
// Accept clang options under the /clang: flag. // Accept clang options under the /clang: flag.
// The first test case ensures that the SLP vectorizer is on by default and that // The first test case ensures that the SLP vectorizer is on by default and that
// it's being turned off by the /clang:-fno-slp-vectorize flag. // it's being turned off by the /clang:-fno-slp-vectorize flag.
// RUN: %clang_cl -O2 -### -- %s 2>&1 | FileCheck -check-prefix=NOCLANG %s // RUN: %clang_cl -O2 -### -- %s 2>&1 | FileCheck -check-prefix=NOCLANG %s
Show All 11 Lines