HomePhabricator

[tsan, go] fix Go windows build

Authored by vitalybuka on Oct 7 2019, 4:11 PM.

Description

[tsan, go] fix Go windows build

Summary:
Don't use weak exports when building tsan into a shared library for Go. gcc can't handle the pragmas used to make the weak references.

Include files that have been added since the last update to build.bat. (We should really find a better way to list all the files needed.)

Add windows version defines (WINVER and _WIN32_WINNT) to get AcquireSRWLockExclusive and ReleaseSRWLockExclusive defined.

Define GetProcessMemoryInfo to use the kernel32 version. This is kind of a hack, the windows header files should do this translation for us. I think we're not in the right family partition (we're using Desktop, but that translation only happens for App and System partitions???), but hacking the family partition seems equally gross and I have no idea what the consequences of that might be.

Patch by Keith Randall.

Reviewers: dvyukov, vitalybuka

Reviewed By: vitalybuka

Subscribers: jfb, delcypher, #sanitizers, llvm-commits

Tags: #llvm, #sanitizers

Differential Revision: https://reviews.llvm.org/D68599

llvm-svn: 373984

Details

Committed
vitalybukaOct 7 2019, 4:11 PM
Reviewer
vitalybuka
Differential Revision
D68599: [tsan, go] fix Go windows build
Parents
rG205910563786: [tsan, go] break commands into multiple lines
Branches
Unknown
Tags
Unknown