This is an archive of the discontinued LLVM Phabricator instance.

DWIMy filterspecs for dotest.py
ClosedPublic

Authored by lawrence_danna on Oct 5 2019, 3:48 PM.

Details

Summary

dotest.py currently requires a filterspec to be of the
form TestCase.test_method. This patch makes it more
flexible, so you can pass TestModule.TestCase.test_method
or TestModule.TestCase or TestCase.test_method or just
test_method.

This makes it more convenient to just copy a test name
out of the terminal after running a bunch of tests and use
it as a filterspec.

Event Timeline

lawrence_danna created this revision.Oct 5 2019, 3:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2019, 3:48 PM
labath added a comment.Oct 7 2019, 4:41 AM

Sounds reasonable to me. The existing filtering method was indeed quite tricky to use. Does anyone else have any opinions on this?

labath added a comment.Oct 7 2019, 4:42 AM

(Also, the documentation for the -f option should be updated to reflect the new functionality.)

This is great, and will make the -f option much easier to use.

updated help text

JDevlieghere accepted this revision.Oct 7 2019, 5:19 PM

Thanks!

This revision is now accepted and ready to land.Oct 7 2019, 5:19 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2019, 10:24 PM