Page MenuHomePhabricator

[scudo][standalone] Make malloc_info return a minimal XML
ClosedPublic

Authored by cryptoad on Oct 3 2019, 2:53 PM.

Details

Summary

Initially, our malloc_info was returning ENOTSUP, but Android would
rather have it return successfully and write a barebone XML to the
stream, so we will oblige.

Add an associated test.

Diff Detail

Repository
rL LLVM

Event Timeline

cryptoad created this revision.Oct 3 2019, 2:53 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 3 2019, 2:53 PM
Herald added subscribers: Restricted Project, delcypher. · View Herald Transcript
cryptoad updated this revision to Diff 223106.Oct 3 2019, 2:58 PM

Changing the version to "scudo-1" as per privately conveyed request.

Apparently clang-formatting the tests found an extraneous space in combined_test.cpp as well.

morehouse accepted this revision.Oct 3 2019, 3:24 PM
morehouse added inline comments.
lib/scudo/standalone/tests/wrappers_c_test.cpp
294 ↗(On Diff #223106)

Nit: If we move fclose to before the strncmp, we don't need to fflush.

This revision is now accepted and ready to land.Oct 3 2019, 3:24 PM
cryptoad updated this revision to Diff 223113.Oct 3 2019, 3:25 PM

Addressing Matt's review comment.

cryptoad marked an inline comment as done.Oct 3 2019, 3:25 PM
This revision was automatically updated to reflect the committed changes.