Page MenuHomePhabricator

[AMDGPU][SILoadStoreOptimizer] NFC: Refactor code
ClosedPublic

Authored by piotr on Oct 3 2019, 5:26 AM.

Details

Summary

This patch fixes a potential aliasing problem in InstClassEnum,
where local values were mixed with machine opcodes.

Introducing InstSubclass will keep them separate and help extending
InstClassEnum with other instruction types (e.g. MIMG) in the future.

This patch also makes getSubRegIdxs() more concise.

Diff Detail

Repository
rL LLVM

Event Timeline

piotr created this revision.Oct 3 2019, 5:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2019, 5:26 AM
arsenm accepted this revision.Oct 3 2019, 10:13 AM

LGTM

This revision is now accepted and ready to land.Oct 3 2019, 10:13 AM
This revision was automatically updated to reflect the committed changes.