Page MenuHomePhabricator

[TimeProfiler] Fix "OptModule" section and add new "Backend" sections
AcceptedPublic

Authored by anton-afanasyev on Sep 27 2019, 2:53 PM.

Details

Summary

Remove unnecessary "OptModule" section. Add "PerFunctionPasses", "PerModulePasses" and "CodeGenPasses" sections under "Backend" section.

Diff Detail

Event Timeline

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptSep 27 2019, 2:53 PM
lebedev.ri accepted this revision.Sep 27 2019, 3:24 PM
lebedev.ri added a reviewer: thakis.

Oh nice!



I like this.

One more related question - there are two "Frontend" sections, second one appears to consist only of "CodeGen Function"s.
Is that correct? Should they both be in an actual front-end section, and should they be renamed to, i dunno,
"Sema" and "Codegen"? I'm not sure about this, just raising a question.

This revision is now accepted and ready to land.Sep 27 2019, 3:24 PM

Oh nice!



I like this.

One more related question - there are two "Frontend" sections, second one appears to consist only of "CodeGen Function"s.
Is that correct? Should they both be in an actual front-end section, and should they be renamed to, i dunno,
"Sema" and "Codegen"? I'm not sure about this, just raising a question.

Ok, committing this.

As for two "Frontend" sections -- we've discussed this several months ago (https://reviews.llvm.org/D63325#1544555), it is not obvious how to join these sections to one (start and finish of such section are separated a lot and the code for joining is opaque).