Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
clang-tools-extra/clangd/FindTarget.cpp | ||
---|---|---|
478 ↗ | (On Diff #222104) | can you explain why these two are special and get to keep Alias decls? Whereas the others dont? |
clang-tools-extra/clangd/FindTarget.cpp | ||
---|---|---|
478 ↗ | (On Diff #222104) | There are two cases to consider for a reference of the form Templ<int> in type positions:
template <class X> Templ = vector<X>; in this case targetDecl returns Templ with mask Alias | TemplatePattern and vector<int> with mask Underlying
in this case targetDecl returns Templ with mask TemplatePattern and that's what we want to return, since this is what was written in the source code. So in both cases the important thing is to not filter-out the result with mask Alias. This is exactly what this patch does. |
LGTM.
clang-tools-extra/clangd/FindTarget.cpp | ||
---|---|---|
478 ↗ | (On Diff #222104) | thanks! I was rather asking for comments in the code though :D Please also mention them in comments. |