[clangd][vscode] Add npm helper commands to package/release the extension.

[hokein]

Summary

Help to fix https://github.com/clangd/clangd/issues/159.

[ilya-biryukov]

clang-tools-extra/clangd/clients/clangd-vscode/package.json

38

Just to make sure I understand what's going on...

Could you explain what --baseImagesUrl does?
The suggested url returns an error code when I try to load it in a browser.

[hokein]

clang-tools-extra/clangd/clients/clangd-vscode/package.json

38

This is expected, this is a base url. it is used to assemble a full url with the screenshot links in the readme, an example is https://raw.githubusercontent.com/llvm/llvm-project/master/clang-tools-extra/clangd/clients/clangd-vscode/ + doc-assets/complete.png, so that the screenshot can be rendered correctly in the VSCode market.

[ilya-biryukov]

LGTM

clang-tools-extra/clangd/clients/clangd-vscode/package.json

38

Thanks for the clarification! Surprised we need this for both package and publish, I'd expect this to be handled in either first or the second step, but not both. I guess I don't fully understand what they do with this URL.

NIT: could add a comment mentioning that this URL is used to "host images (e.g. screenshots in documentation)"?

[hokein]

clang-tools-extra/clangd/clients/clangd-vscode/package.json

38

Thanks for the clarification! Surprised we need this for both package and publish, I'd expect this to be handled in either first or the second step, but not both. I guess I don't fully understand what they do with this URL.

Actually, when we make a new release, we use publish which includes the package. The package is usually used to build a local package (mainly for debugging purpose).

NIT: could add a comment mentioning that this URL is used to "host images (e.g. screenshots in documentation)"?

Unfortunately, comment is not permitted in the JSON :(

clang-tools-extra/clangd/clients/clangd-vscode/DEVELOPING.md

 
 ## Steps
 
 ```bash
   $ cd /path/to/clang-tools-extra/clangd/clients/clangd-vscode/
   # For the first time, you need to login in the account. vsce will ask you for
     the Personal Access Token, and remember it for future commands.
   $ vsce login llvm-vs-code-extensions
-  # Make sure the screenshots in the readme are rendered in VSCode marketplace.
-  $ vsce publish --baseImagesUrl https://raw.githubusercontent.com/llvm/llvm-project/master/clang-tools-extra/clangd/clients/clangd-vscode/
+  # Publish the extension to the VSCode marketplace.
+  $ npm run publish
 ```

clang-tools-extra/clangd/clients/clangd-vscode/package.json

"activationEvents": [
         "onCommand:clangd-vscode.activate"
     ],
     "main": "./out/src/extension",
     "scripts": {
         "vscode:prepublish": "tsc -p ./",
         "compile": "tsc -watch -p ./",
         "postinstall": "node ./node_modules/vscode/bin/install",
         "format": "clang-format --style=LLVM -i --glob=\"{src,test}/*.ts\"",
-        "test": "node ./node_modules/vscode/bin/test"
+        "test": "node ./node_modules/vscode/bin/test",
+        "package": "vsce package --baseImagesUrl https://raw.githubusercontent.com/llvm/llvm-project/master/clang-tools-extra/clangd/clients/clangd-vscode/",
+        "publish": "vsce publish --baseImagesUrl https://raw.githubusercontent.com/llvm/llvm-project/master/clang-tools-extra/clangd/clients/clangd-vscode/"
     },
     "dependencies": {
         "jsonc-parser": "^2.1.0",
         "vscode-languageclient": "^5.3.0-next.6",
         "vscode-languageserver": "^5.3.0-next.6",
         "vscode-languageserver-types": "^3.14.0"
     },
     "devDependencies": {