Page MenuHomePhabricator

cmake: Link lldb libraries and tools with libclang-cpp.so when CLANG_LINK_LLVM_DYLIB=ON
AbandonedPublic

Authored by tstellar on Sep 25 2019, 9:38 PM.

Event Timeline

tstellar created this revision.Sep 25 2019, 9:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2019, 9:38 PM
mgorny added a comment.Oct 4 2019, 2:33 PM

Would it be bad if I said I like mine more? I'm not a fan of implicit logic, and relying on specific filenames.

Would it be bad if I said I like mine more? I'm not a fan of implicit logic, and relying on specific filenames.

No, that's fine. I actually started to implement it the same way as your patch, but I was worried I would miss some cases, so I went with this approach. We can drop this one.

Not saying this will happen here but in clang-tools-extra, I had to deal with some clang* libraries being part of libclang-cpp, and some (those added by cte) being not.

tstellar abandoned this revision.Nov 15 2019, 8:55 AM