Page MenuHomePhabricator

[CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER
ClosedPublic

Authored by JDevlieghere on Sep 24 2019, 3:23 PM.

Details

Summary

r366433 broke support for the system debugserver. Although the change was well-intended, it (presumably) unintentionally removed the logic to copy over the debugserver. As a result, even with LLDB_USE_SYSTEM_DEBUGSERVER enabled, we ended up building, signing and using the just-built debugserver. This patch partially recovers the old behavior: when LLDB_USE_SYSTEM_DEBUGSERVER is set we don't build debugserver and just copy over the system one.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Sep 24 2019, 3:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2019, 3:23 PM
Herald added a subscriber: mgorny. · View Herald Transcript

Add decorator to tests that require a more recent debugserver.

xiaobai added inline comments.Sep 24 2019, 3:30 PM
lldb/test/CMakeLists.txt
103 ↗(On Diff #221607)

Doesn't this now conflict with the use of --out-of-tree-debugserver added to the args below?

JDevlieghere marked an inline comment as done.Sep 24 2019, 3:35 PM
JDevlieghere added inline comments.
lldb/test/CMakeLists.txt
103 ↗(On Diff #221607)

--out-of-tree-debugserver tells dotest that test decorated with skipIfOutOfTreeDebugserver should be skipped during this run.

xiaobai accepted this revision.Sep 24 2019, 3:36 PM

No objections from me.

This revision is now accepted and ready to land.Sep 24 2019, 3:36 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2019, 3:37 PM
aprantl added inline comments.Sep 24 2019, 4:01 PM
lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyBreakpoints.py
18

It may be more forward-looking to check for an actual version here like we do for the compiler.