- Add a overrloded URI::resolve, which accepts a string URI;
- also fixed some callside that don't check the error;
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 38430 Build 38429: arc lint + arc unit
Event Timeline
LGTM, thanks!
clang-tools-extra/clangd/FindSymbols.cpp | ||
---|---|---|
48–49 | return make_string_error(... ? Also the error string regarding CD.FileURI should be contained in Path.takeError maybe just print: | |
clang-tools-extra/clangd/URI.cpp | ||
190 | why not just Uri.takeError ? same below for Path.takeError | |
clang-tools-extra/clangd/URI.h | ||
66 | what about: Same as above, in addition parses \p FileURI using URI::parse to create a URI. | |
clang-tools-extra/clangd/index/BackgroundIndexLoader.cpp | ||
30 | wow, thanks for catching this one. Failed to resolve URI {0}: {1} |
clang-tools-extra/clangd/index/BackgroundIndexLoader.cpp | ||
---|---|---|
30 | actually can you just inline this into call site? |
LGTM, thanks!
clang-tools-extra/clangd/FindSymbols.cpp | ||
---|---|---|
48–49 | ah I see, when I searched for make_string_error, there were too many references so I assumed it was a generic helper, but apparently every file has an internal implementation ... Whatever that can be an adventure for another day... |
return make_string_error(... ?
Also the error string regarding CD.FileURI should be contained in Path.takeError maybe just print:
Could not resolve path for symbol '{0}': {1}, Sym.Name, Path.takeError() ?