Page MenuHomePhabricator

[LLD][AARCH64] Small refactor of AArchErrataFix to match changes in ARMErrataFix NFC.
ClosedPublic

Authored by peter.smith on Sep 16 2019, 7:51 AM.

Details

Summary

D67284 introduced ARMErrataFix.cpp which was derived from AArch64ErrataFix.cpp. There were some useful refactoring changes made to ARMErrataFix.cpp made as part of the review. This change applies the relevant changes back to AArch64ErrataFix.cpp. Main changes are:

  • Old style variable names in comments like IS, are now new style isec.
  • Simplify init() collection of mappingSymbols to always start with a code mapping symbol.
  • Simplify logic in mergeCmp().
  • Fix one 80 column overflow caused by IS -> isec transformation.

Diff Detail

Repository
rL LLVM

Event Timeline

peter.smith created this revision.Sep 16 2019, 7:51 AM
MaskRay added inline comments.Sep 16 2019, 9:47 AM
ELF/AArch64ErrataFix.cpp
467 ↗(On Diff #220342)

The outer () can probably be removed.

470 ↗(On Diff #220342)

Missing full stop.

peter.smith marked 2 inline comments as done.

Thanks for the comments. Uploaded new patch with fixes.

MaskRay accepted this revision.Sep 16 2019, 9:36 PM

Thanks for the clean-up!

This revision is now accepted and ready to land.Sep 16 2019, 9:36 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 17 2019, 2:49 AM