Page MenuHomePhabricator

[NFC][libLTO] Rearrange declaration in lto.h
ClosedPublic

Authored by steven_wu on Sep 13 2019, 10:38 AM.

Details

Summary

Rearrange the function declaration in lto.h so they falls in the correct
grouping.

Diff Detail

Repository
rL LLVM

Event Timeline

steven_wu created this revision.Sep 13 2019, 10:38 AM
Herald added a project: Restricted Project. · View Herald Transcript

I am not very familiar with the C API, but wondering if they belong in the ThinLTO group which is where they move with this patch? What determines the correct group?

Sorry, should be clear that this is for doxygen documents. See @defgroup @ingroup from the comments. Those functions where in the Caching APIs group.

I don't see LLVM website is generating documents based on groups but still good to get it correct.

Just want to clean this up because I am planning to add some new APIs.

Sorry, should be clear that this is for doxygen documents. See @defgroup @ingroup from the comments. Those functions where in the Caching APIs group.

I don't see LLVM website is generating documents based on groups but still good to get it correct.

Just want to clean this up because I am planning to add some new APIs.

I get why they don't belong in the caching section, but now they are in the ThinLTO-specific section (LLVMCTLTO). Should they be in the earlier LLVMCLTO section which seems to include more of the generic LTO interfaces?

Sorry, should be clear that this is for doxygen documents. See @defgroup @ingroup from the comments. Those functions where in the Caching APIs group.

I don't see LLVM website is generating documents based on groups but still good to get it correct.

Just want to clean this up because I am planning to add some new APIs.

I get why they don't belong in the caching section, but now they are in the ThinLTO-specific section (LLVMCTLTO). Should they be in the earlier LLVMCLTO section which seems to include more of the generic LTO interfaces?

I got fooled by the //endgroup comment. I will fix that as well.

  • [LTO][Legacy] Add new C inferface to query libcall functions

Update to put the functions in the correct group.

This revision is now accepted and ready to land.Sep 13 2019, 2:08 PM
This revision was automatically updated to reflect the committed changes.