Page MenuHomePhabricator

[Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX
ClosedPublic

Authored by xiaobai on Sep 10 2019, 5:50 PM.

Details

Summary

InferiorCallPOSIX directly grabs a ClangASTContext from the Target it
has and does no error checking. I don't think these functions have a
reason to know about clang specifically. Additionally, using
GetScratchTypeSystemForLanguage forces us to do error checking since
it returns an Expected.

Event Timeline

xiaobai created this revision.Sep 10 2019, 5:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 10 2019, 5:50 PM
JDevlieghere accepted this revision.Sep 10 2019, 6:13 PM
This revision is now accepted and ready to land.Sep 10 2019, 6:13 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 11 2019, 1:35 PM