This is an archive of the discontinued LLVM Phabricator instance.

Move LLVM_ENABLE_ABI_BREAKING_CHECKS to its own file
ClosedPublic

Authored by echristo on Sep 10 2019, 1:29 AM.

Details

Summary

Move LLVM_ENABLE_ABI_BREAKING_CHECKS variables to their own file so that you don't have to link Error.o and all of its dependencies.

Tested by building everything.

Diff Detail

Event Timeline

echristo created this revision.Sep 10 2019, 1:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 10 2019, 1:29 AM
lattner accepted this revision.Sep 10 2019, 9:30 AM
lattner added a subscriber: lattner.

Awesome, thanks Eric! This is very useful for projects that want to use LLVM Support library but also care about codesize.

This revision is now accepted and ready to land.Sep 10 2019, 9:30 AM

Might be worth having some more detail in the commit message to explain why -ffunction-sections/-gc-sections isn't sufficient to remove the binary size increase.

(also, might be worth tracking down the global initializers that were causing this to have a binary size cost - seeing if those can be removed too)

This revision was automatically updated to reflect the committed changes.

Might be worth having some more detail in the commit message to explain why -ffunction-sections/-gc-sections isn't sufficient to remove the binary size increase.

(also, might be worth tracking down the global initializers that were causing this to have a binary size cost - seeing if those can be removed too)

Good idea btw, I did that before I committed :)