Add support for evaluating DW_OP_entry_value. This involves parsing
DW_TAG_call_site_parameter and wiring the information through to the expression
evaluator.
rdar://54496008
Paths
| Differential D67376
[DWARF] Evaluate DW_OP_entry_value ClosedPublic Authored by vsk on Sep 9 2019, 3:32 PM.
Details Summary Add support for evaluating DW_OP_entry_value. This involves parsing rdar://54496008
Diff Detail
Event TimelineComment Actions This is very exciting!
Comment Actions TODO:
vsk marked an inline comment as done. Comment Actions
vsk marked an inline comment as done. Comment ActionsWhile tightening up the test case I think I found an issue with the way inlined frames are handled. I need to take a closer look.
vsk marked 4 inline comments as done. Comment Actions
I'm happy with the test coverage now, and think that I've addressed all the feedback. PTAL, thanks!
Comment Actions Looking great! I have one more question inline, but that is mostly about documenting the algorithm.
vsk marked 3 inline comments as done. Comment Actions
This revision is now accepted and ready to land.Sep 11 2019, 1:16 PM Closed by commit rL371668: [DWARF] Evaluate DW_OP_entry_value (authored by vedantk). · Explain WhySep 11 2019, 2:23 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 219804 lldb/trunk/include/lldb/Symbol/Function.h
lldb/trunk/packages/Python/lldbsuite/test/decorators.py
lldb/trunk/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/Makefile
lldb/trunk/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/TestBasicEntryValuesX86_64.py
lldb/trunk/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp
lldb/trunk/source/Expression/DWARFExpression.cpp
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDefines.cpp
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
lldb/trunk/source/Symbol/Function.cpp
|