Page MenuHomePhabricator

[SCEV] Generalize SCEVParameterRewriter to accept SCEV expression as target.
AcceptedPublic

Authored by fhahn on Sep 4 2019, 8:10 AM.

Details

Summary

This patch extends SCEVParameterRewriter to support rewriting unknown
epxressions to arbitrary SCEV expressions. It will be used by further
patches.

Event Timeline

fhahn created this revision.Sep 4 2019, 8:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 4 2019, 8:10 AM
fhahn added a comment.Sep 11 2019, 9:03 AM

Ping. Do you think this is helpful on its own? I'll rework the main motivation (D67178), but it still would be useful IMO, e.g. for the test case in D67177.

reames accepted this revision.Oct 28 2019, 11:26 AM

LGTM.

I don't really have the context to evaluate this fully, so I'm mostly deferring to author. I don't see any obvious problems, and the generalization does look useful. I just don't know the callsite well enough to be certain this has the desired effect, and thus the need to defer to author.

This revision is now accepted and ready to land.Oct 28 2019, 11:26 AM