This is an archive of the discontinued LLVM Phabricator instance.

[MachinePipeliner] Separate schedule emission, NFC
ClosedPublic

Authored by jmolloy on Aug 30 2019, 7:24 AM.

Details

Summary

This is the first stage in refactoring the pipeliner and making it more
accessible for backends to override and control. This separates the logic and
state required to *emit* a scheudule from the logic that *computes* and
validates a schedule.

This will enable (a) new schedule emitters and (b) new modulo scheduling
implementations to coexist.

NFC. Most of the code in ModuloSchedule.cpp is moved over from MachinePipeliner.cpp. This code is very complex and so I will not be touching this code in this review any more than necessary to keep this review NFC.

Diff Detail

Repository
rL LLVM

Event Timeline

jmolloy created this revision.Aug 30 2019, 7:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2019, 7:24 AM
jmolloy updated this revision to Diff 218101.Aug 30 2019, 7:39 AM

Remove commented out code, add CMakeLists.txt entry.

ThomasRaoux accepted this revision.Aug 30 2019, 9:28 AM

Looks good to me.

This revision is now accepted and ready to land.Aug 30 2019, 9:28 AM
This revision was automatically updated to reflect the committed changes.