This is an archive of the discontinued LLVM Phabricator instance.

[ASTImporter][NFC] Add comments to code where we cannot use HandleNameConflict
Needs ReviewPublic

Authored by martong on Aug 30 2019, 5:56 AM.

Details

Summary

This is the continuation of https://reviews.llvm.org/D59692 where we started to
use HandleNameConflict in almost all cases.
The remaining cases are dealt with here.

Event Timeline

martong created this revision.Aug 30 2019, 5:56 AM
shafik added inline comments.Aug 30 2019, 3:25 PM
clang/lib/AST/ASTImporter.cpp
3454

Do we have an example that hits this case?

5262

I believe this is ill-formed no diagnostic required.