Page MenuHomePhabricator

[clangd][vscode] Don't leak the resources
ClosedPublic

Authored by hokein on Aug 28 2019, 6:55 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

hokein created this revision.Aug 28 2019, 6:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2019, 6:55 AM

Oh, was not aware we needed to dispose the extension as well.

I think you should probably add the SemanticHighlightingFeature to the context.subscriptions as well, right? (because I didn't when I did the cleanup patch for it, sorry)

hokein updated this revision to Diff 217657.Aug 28 2019, 8:00 AM

dispose the semanticHighlighting feature as well.

Oh, was not aware we needed to dispose the extension as well.

I think you should probably add the SemanticHighlightingFeature to the context.subscriptions as well, right? (because I didn't when I did the cleanup patch for it, sorry)

good catch, done.

jvikstrom accepted this revision.Aug 28 2019, 8:04 AM
This revision is now accepted and ready to land.Aug 28 2019, 8:04 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2019, 8:08 AM