[clangd][vscode] Don't leak the resources

[hokein]

Summary

We miss a few places where we need to add them to the subscriptions.

[jvikstrom]

Oh, was not aware we needed to dispose the extension as well.

I think you should probably add the SemanticHighlightingFeature to the context.subscriptions as well, right? (because I didn't when I did the cleanup patch for it, sorry)

[hokein]

dispose the semanticHighlighting feature as well.

[hokein]

In D66881#1649044, @jvikstrom wrote:

Oh, was not aware we needed to dispose the extension as well.

I think you should probably add the SemanticHighlightingFeature to the context.subscriptions as well, right? (because I didn't when I did the cleanup patch for it, sorry)

good catch, done.

clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts

const clientOptions: vscodelc.LanguageClientOptions = {
         // Do not switch to output window when clangd returns output
         revealOutputChannelOn: vscodelc.RevealOutputChannelOn.Never
     };
 
   const clangdClient = new ClangdLanguageClient('Clang Language Server',
                                                 serverOptions, clientOptions);
   const semanticHighlightingFeature =
       new semanticHighlighting.SemanticHighlightingFeature();
+  context.subscriptions.push(
+      vscode.Disposable.from(semanticHighlightingFeature));
   clangdClient.registerFeature(semanticHighlightingFeature);
   console.log('Clang Language Server is now active!');
   context.subscriptions.push(clangdClient.start());
   context.subscriptions.push(vscode.commands.registerCommand(
       'clangd-vscode.switchheadersource', async () => {
         const uri =
             vscode.Uri.file(vscode.window.activeTextEditor.document.fileName);
         if (!uri) {
           return;
         }
         const docIdentifier =
             vscodelc.TextDocumentIdentifier.create(uri.toString());
         const sourceUri = await clangdClient.sendRequest(
             SwitchSourceHeaderRequest.type, docIdentifier);
         if (!sourceUri) {
           return;
         }
         const doc = await vscode.workspace.openTextDocument(
             vscode.Uri.parse(sourceUri));
         vscode.window.showTextDocument(doc);
       }));
   const status = new FileStatus();
+  context.subscriptions.push(vscode.Disposable.from(status));
   context.subscriptions.push(vscode.window.onDidChangeActiveTextEditor(
       () => { status.updateStatus(); }));
-  clangdClient.onDidChangeState(({newState}) => {
+  context.subscriptions.push(clangdClient.onDidChangeState(({newState}) => {
     if (newState == vscodelc.State.Running) {
       // clangd starts or restarts after crash.
       clangdClient.onNotification(
           'textDocument/clangd.fileStatus',
           (fileStatus) => { status.onFileUpdated(fileStatus); });
       clangdClient.onNotification(
           semanticHighlighting.NotificationType,
           semanticHighlightingFeature.handleNotification.bind(
               semanticHighlightingFeature));
     } else if (newState == vscodelc.State.Stopped) {
       // Clear all cached statuses when clangd crashes.
       status.clear();
       semanticHighlightingFeature.dispose();
     }
-  })
+  }));
   // An empty place holder for the activate command, otherwise we'll get an
   // "command is not registered" error.
   context.subscriptions.push(vscode.commands.registerCommand(
       'clangd-vscode.activate', async () => {}));
 }