Page MenuHomePhabricator

[Tblgen][MCA] Add the ability to mark groups as LoadQueue and StoreQueue. NFCI
ClosedPublic

Authored by andreadb on Aug 27 2019, 10:36 AM.

Details

Summary

Before this patch, users were not allowed to optionally mark processor resource
groups as load/store queues. That is because tablegen class MemoryQueue was
originally declared as expecting a ProcResource template argument (instead of a
more generic ProcResourceKind).

That was an oversight, since the original intention from D54957 was to let user
mark any processor resource as either load/store queue. This patch adds the
ability to use processor resource groups in MemoryQueue definitions. This is not
a user visible change.

Diff Detail

Event Timeline

andreadb created this revision.Aug 27 2019, 10:36 AM
mattd accepted this revision.Aug 27 2019, 10:43 AM

LGTM, nice change! I assume all of the existing LSUnit testing is sufficient.

This revision is now accepted and ready to land.Aug 27 2019, 10:43 AM

LGTM, nice change! I assume all of the existing LSUnit testing is sufficient.

Yes. It is not going to affect any of the upstream models.
Thanks for the review!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2019, 11:29 AM
Herald added a subscriber: hiraditya. · View Herald Transcript