Page MenuHomePhabricator

Add GWP-ASan fuzz target to compiler-rt/tools.
ClosedPublic

Authored by hctim on Aug 26 2019, 5:08 PM.

Details

Summary

@eugenis to approve addition of //compiler-rt/tools.
@pree-jackie please confirm that this WFY.

D66494 introduced the GWP-ASan stack_trace_compressor_fuzzer. Building fuzz
targets in compiler-rt is a new affair, and has some challenges:

  • If the host compiler doesn't have compiler-rt, the -fsanitize=fuzzer may not be able to link against libclang_rt.fuzzer*.
  • Things in compiler-rt generally aren't built when you want to build with sanitizers using -DLLVM_USE_SANITIZER. This tricky to work around, so we create the new tools directory so that we can build fuzz targets with sanitizers. This has the added bonus of fixing the problem above as well, as we can now just guard the fuzz target build to only be done with -DLLVM_USE_SANITIZE_COVERAGE=On.

Diff Detail

Event Timeline

hctim created this revision.Aug 26 2019, 5:08 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 26 2019, 5:08 PM
Herald added subscribers: llvm-commits, Restricted Project, mgorny, dberris. · View Herald Transcript
pree-jackie accepted this revision.Aug 27 2019, 8:15 AM

This builds llvm fine, thanks a lot for working on this :)

This revision is now accepted and ready to land.Aug 27 2019, 8:15 AM

Submission is broken currently due to the upstream SVN issues. Will submit when it's available. Thanks for your patience.

This revision was automatically updated to reflect the committed changes.