Page MenuHomePhabricator

pree-jackie (Praveen velliengiri )
Animal

Projects

User does not belong to any projects.

User Details

User Since
Mar 13 2018, 2:12 AM (82 w, 5 d)

Recent Activity

Sep 3 2019

Herald added a project to D49663: [x86/SLH] Teach the x86 speculative load hardening pass to harden against v1.2 BCBS attacks directly.: Restricted Project.
Sep 3 2019, 12:25 AM · Restricted Project

Aug 27 2019

pree-jackie committed rL370092: [ORCv2] - New Speculate Query Implementation.
[ORCv2] - New Speculate Query Implementation
Aug 27 2019, 11:38 AM
pree-jackie committed rG3b1b56d3fb9e: [ORCv2] - New Speculate Query Implementation (authored by pree-jackie).
[ORCv2] - New Speculate Query Implementation
Aug 27 2019, 11:30 AM
pree-jackie closed D66399: [ORCv2] - New Speculate Query Implementation.
Aug 27 2019, 11:30 AM · Restricted Project, Unknown Object (Project)
pree-jackie committed rL370085: [ORC] NFC remove unimplemented query.
[ORC] NFC remove unimplemented query
Aug 27 2019, 11:19 AM
pree-jackie committed rG92bfb69a44e9: [ORC] NFC remove unimplemented query (authored by pree-jackie).
[ORC] NFC remove unimplemented query
Aug 27 2019, 11:12 AM
pree-jackie closed D66289: [ORC] NFC remove unimplemented query.
Aug 27 2019, 11:12 AM · Restricted Project
pree-jackie accepted D66776: Add GWP-ASan fuzz target to compiler-rt/tools..

This builds llvm fine, thanks a lot for working on this :)

Aug 27 2019, 8:22 AM · Restricted Project, Restricted Project

Aug 26 2019

pree-jackie added a comment to D66399: [ORCv2] - New Speculate Query Implementation.

Committing tomorrow as it is difficult to watch build bots continuously now.

Aug 26 2019, 1:11 PM · Restricted Project, Unknown Object (Project)
pree-jackie updated the diff for D66399: [ORCv2] - New Speculate Query Implementation.

else-after-return fixes. Going to commit

Aug 26 2019, 8:59 AM · Restricted Project, Unknown Object (Project)

Aug 24 2019

pree-jackie updated the diff for D66399: [ORCv2] - New Speculate Query Implementation.

I resolved N-1 comments. Plus, this change set implements the launching bulk speculative queries and locking the module before instrumenting.
I kindly request you to review the else-after-return resolved part of code, to check whether I understand it correctly.

Aug 24 2019, 8:03 AM · Restricted Project, Unknown Object (Project)
pree-jackie added a comment to D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer..

@hctim This breaks the debug build of llvm when the host compiler doesn't build with compiler-rt. I build llvm/clang (release build) as a host compiler, to build llvm,compiler-rt (debug) build. Unfortunately, while building the debug build, the process tries to find the already installed compiler-rt of the host compiler (which is not present). Do you have any guidelines?

Aug 24 2019, 1:53 AM · Restricted Project, Restricted Project

Aug 23 2019

pree-jackie added inline comments to D66399: [ORCv2] - New Speculate Query Implementation.
Aug 23 2019, 9:11 AM · Restricted Project, Unknown Object (Project)

Aug 19 2019

pree-jackie added inline comments to D66399: [ORCv2] - New Speculate Query Implementation.
Aug 19 2019, 3:57 PM · Restricted Project, Unknown Object (Project)
pree-jackie added inline comments to D66399: [ORCv2] - New Speculate Query Implementation.
Aug 19 2019, 3:40 PM · Restricted Project, Unknown Object (Project)
pree-jackie added a comment to D66441: [cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC.

I already has a patch for this, but it is still in review because of unrelated stuff to this issue. So please go head and commit this.

Aug 19 2019, 3:05 PM · Restricted Project
pree-jackie accepted D66441: [cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC.
Aug 19 2019, 3:05 PM · Restricted Project
pree-jackie added inline comments to D66399: [ORCv2] - New Speculate Query Implementation.
Aug 19 2019, 1:15 PM · Restricted Project, Unknown Object (Project)

Aug 18 2019

pree-jackie created D66399: [ORCv2] - New Speculate Query Implementation.
Aug 18 2019, 2:21 PM · Restricted Project, Unknown Object (Project)

Aug 15 2019

pree-jackie created D66289: [ORC] NFC remove unimplemented query.
Aug 15 2019, 5:59 AM · Restricted Project

Aug 4 2019

pree-jackie closed D63378: [ORC] WIP Speculative compilation.

The change set is committed in rL367756.

Aug 4 2019, 6:02 AM · Restricted Project, Unknown Object (Project)

Aug 3 2019

pree-jackie committed rGf5c40cb9002a: Speculative Compilation (authored by pree-jackie).
Speculative Compilation
Aug 3 2019, 7:42 AM
pree-jackie committed rL367756: Speculative Compilation.
Speculative Compilation
Aug 3 2019, 7:42 AM
pree-jackie updated the diff for D63378: [ORC] WIP Speculative compilation.

Adapt to new locking scheme

Aug 3 2019, 6:35 AM · Restricted Project, Unknown Object (Project)

Aug 1 2019

pree-jackie updated the diff for D63378: [ORC] WIP Speculative compilation.

Resolve comments

Aug 1 2019, 9:34 AM · Restricted Project, Unknown Object (Project)

Jul 31 2019

pree-jackie added inline comments to D63378: [ORC] WIP Speculative compilation.
Jul 31 2019, 1:24 PM · Restricted Project, Unknown Object (Project)
pree-jackie updated the diff for D63378: [ORC] WIP Speculative compilation.
  1. Included a Example to show how to use speculation,
Jul 31 2019, 9:38 AM · Restricted Project, Unknown Object (Project)

Jul 17 2019

pree-jackie updated the summary of D63378: [ORC] WIP Speculative compilation.
Jul 17 2019, 1:52 PM · Restricted Project, Unknown Object (Project)
pree-jackie added a comment to D64443: Add support for building with Python 3.

I reverse the list as 2.7 3.5 3.6 3.7 it fixes the issue, but I don't know whether it is correct or not.

Jul 17 2019, 5:48 AM · Restricted Project
pree-jackie added a comment to D64443: Add support for building with Python 3.

Hey guys, I get cmake error at configuration time " Found incompatible python interpreter version and python libraries version". I have both python 2.7 and python 3.6, cmake now finds python interpreter version 3.6 and python libs 2.7, hence the incompatibility. How I can rectify this?

Jul 17 2019, 5:33 AM · Restricted Project

Jul 13 2019

Herald added a project to D25186: NFC: The Cost Model specialization: Restricted Project.
Jul 13 2019, 12:59 PM · Restricted Project

Jul 9 2019

pree-jackie added inline comments to D63378: [ORC] WIP Speculative compilation.
Jul 9 2019, 11:31 AM · Restricted Project, Unknown Object (Project)
pree-jackie added a comment to D63378: [ORC] WIP Speculative compilation.

lhames idea :

Remove Speculator variants for different program representations and handle them via ORC Layers.
Jul 9 2019, 11:31 AM · Restricted Project, Unknown Object (Project)
pree-jackie updated the diff for D63378: [ORC] WIP Speculative compilation.

lhames idea :

Jul 9 2019, 11:31 AM · Restricted Project, Unknown Object (Project)
pree-jackie added a comment to D63378: [ORC] WIP Speculative compilation.

Hi Praveen,

I'm not sure the IRSpeculator is necessary. My instinct would be to just have the Speculator class as the global repository of estimates of the form "execution point -> { candidates to speculatively compile }" (i.e. your GlobalSpecMap). Then the IRSpeculationLayer should take a reference to the Speculator and use a custom FunctionPass to populates the estimates.

I've attached an example of a hand rolled pass pipeline that should give you access to statically calculated block frequency estimates:

  • Lang.

I think it is really a matter of separation, that is where we analysis the module and retrieve the results that means whether in a layer or a speculator object, If we take over the layer approach we have to make the Pass to be aware of speculator.

Jul 9 2019, 7:46 AM · Restricted Project, Unknown Object (Project)
pree-jackie added a comment to D63378: [ORC] WIP Speculative compilation.

Hi Praveen,

I'm not sure the IRSpeculator is necessary. My instinct would be to just have the Speculator class as the global repository of estimates of the form "execution point -> { candidates to speculatively compile }" (i.e. your GlobalSpecMap). Then the IRSpeculationLayer should take a reference to the Speculator and use a custom FunctionPass to populates the estimates.

I've attached an example of a hand rolled pass pipeline that should give you access to statically calculated block frequency estimates:

  • Lang.
Jul 9 2019, 7:09 AM · Restricted Project, Unknown Object (Project)

Jul 8 2019

pree-jackie added inline comments to D63378: [ORC] WIP Speculative compilation.
Jul 8 2019, 1:42 PM · Restricted Project, Unknown Object (Project)
pree-jackie added a comment to D63378: [ORC] WIP Speculative compilation.

Can you please upload a patch with full context?

Jul 8 2019, 1:25 PM · Restricted Project, Unknown Object (Project)
pree-jackie updated the diff for D63378: [ORC] WIP Speculative compilation.
Jul 8 2019, 1:25 PM · Restricted Project, Unknown Object (Project)
pree-jackie added a comment to D63378: [ORC] WIP Speculative compilation.

Ping :)

Jul 8 2019, 12:51 PM · Restricted Project, Unknown Object (Project)
pree-jackie updated the diff for D63378: [ORC] WIP Speculative compilation.

Additions in this Change Set

Jul 8 2019, 12:50 PM · Restricted Project, Unknown Object (Project)

Jun 27 2019

pree-jackie updated the diff for D63378: [ORC] WIP Speculative compilation.

Added __orc_speculate_for , and orc_speculator. Remaining are test-cases, once test case is added I think it is ready to go, without major changes

Jun 27 2019, 2:08 AM · Restricted Project, Unknown Object (Project)

Jun 26 2019

pree-jackie added inline comments to D63378: [ORC] WIP Speculative compilation.
Jun 26 2019, 12:41 PM · Restricted Project, Unknown Object (Project)

Jun 23 2019

pree-jackie updated the diff for D63378: [ORC] WIP Speculative compilation.

Fixed comments,

Jun 23 2019, 8:54 AM · Restricted Project, Unknown Object (Project)

Jun 18 2019

pree-jackie added inline comments to D63378: [ORC] WIP Speculative compilation.
Jun 18 2019, 9:08 PM · Restricted Project, Unknown Object (Project)

Jun 17 2019

pree-jackie added a comment to D63377: [ORC] Avoid Race in Assertions .

I think it's more of an race condition than a data race. I will write a test case and check whether TSan can catch it. But the idea here is createJITDylib and getJITdylibByName must be executed by the same thread,

Jun 17 2019, 9:13 PM · Restricted Project

Jun 15 2019

pree-jackie added a comment to D63378: [ORC] WIP Speculative compilation.

Hi Lang, thank you for the comments.
I'm reading those and I'll address those shortly.

Jun 15 2019, 10:39 AM · Restricted Project, Unknown Object (Project)
pree-jackie updated the summary of D63378: [ORC] WIP Speculative compilation.
Jun 15 2019, 8:41 AM · Restricted Project, Unknown Object (Project)
pree-jackie updated the summary of D63378: [ORC] WIP Speculative compilation.
Jun 15 2019, 8:38 AM · Restricted Project, Unknown Object (Project)
pree-jackie updated the summary of D63378: [ORC] WIP Speculative compilation.
Jun 15 2019, 8:38 AM · Restricted Project, Unknown Object (Project)
pree-jackie retitled D63378: [ORC] WIP Speculative compilation from Speculative compilation in ORC to [ORC] WIP Speculative compilation.
Jun 15 2019, 8:37 AM · Restricted Project, Unknown Object (Project)
pree-jackie created D63378: [ORC] WIP Speculative compilation.
Jun 15 2019, 8:14 AM · Restricted Project, Unknown Object (Project)
pree-jackie created D63377: [ORC] Avoid Race in Assertions .
Jun 15 2019, 7:35 AM · Restricted Project

Jun 13 2019

pree-jackie added a comment to D62491: Updating Kaleidoscope tutorial to Synchronize with ORC v2 APIs.

Always Welcome

Jun 13 2019, 11:12 AM · Restricted Project

Jun 4 2019

pree-jackie added a comment to D62491: Updating Kaleidoscope tutorial to Synchronize with ORC v2 APIs.

ping,
Whether docs is okay?

Jun 4 2019, 5:20 AM · Restricted Project

May 31 2019

pree-jackie retitled D62491: Updating Kaleidoscope tutorial to Synchronize with ORC v2 APIs from [WIP] Updating Kaleidoscope tutorial to Synchronize with ORC v2 APIs to Updating Kaleidoscope tutorial to Synchronize with ORC v2 APIs.
May 31 2019, 10:46 AM · Restricted Project

May 30 2019

pree-jackie updated the diff for D62491: Updating Kaleidoscope tutorial to Synchronize with ORC v2 APIs.

Added user documentation part 2, It is ready to go now.

May 30 2019, 10:44 PM · Restricted Project

May 29 2019

pree-jackie updated the diff for D62491: Updating Kaleidoscope tutorial to Synchronize with ORC v2 APIs.

User Documentation - Part 1

May 29 2019, 12:16 PM · Restricted Project
pree-jackie updated the diff for D62491: Updating Kaleidoscope tutorial to Synchronize with ORC v2 APIs.

Adding IRTransformLayer to Optimize IR *Modules* Lazily

May 29 2019, 9:02 AM · Restricted Project

May 27 2019

pree-jackie added a comment to D62491: Updating Kaleidoscope tutorial to Synchronize with ORC v2 APIs.

toy.cpp is already updated for chapter 1&2.

May 27 2019, 11:29 AM · Restricted Project
pree-jackie created D62491: Updating Kaleidoscope tutorial to Synchronize with ORC v2 APIs.
May 27 2019, 10:38 AM · Restricted Project

May 21 2019

pree-jackie added a comment to D62139: Ensuring unique names for JITDylib's.

Thanks :)
Then we can change parameter type of createJITDylib to StringRef instead of std::string.

May 21 2019, 7:25 AM · Restricted Project

May 20 2019

pree-jackie updated the diff for D62139: Ensuring unique names for JITDylib's.

Updated Diff file

May 20 2019, 2:41 PM · Restricted Project
pree-jackie added a comment to D62139: Ensuring unique names for JITDylib's.

Whether two diff set like this can be merged? How I can update these individual diff's to view all changes in a single diff?

May 20 2019, 8:30 AM · Restricted Project
pree-jackie updated the diff for D62139: Ensuring unique names for JITDylib's.

Wrapping the getJITDylibByName by runSessionLocked Interface to make thread safe creation of JITDylibs

May 20 2019, 8:25 AM · Restricted Project
pree-jackie updated the summary of D62139: Ensuring unique names for JITDylib's.
May 20 2019, 6:48 AM · Restricted Project
pree-jackie created D62139: Ensuring unique names for JITDylib's.
May 20 2019, 6:41 AM · Restricted Project

May 11 2019

pree-jackie added a comment to D61793: Fixing typos.

Thank you!

May 11 2019, 7:46 AM · Restricted Project

May 10 2019

pree-jackie created D61793: Fixing typos.
May 10 2019, 10:18 AM · Restricted Project

Apr 18 2019

Herald added a project to D44892: Add PerfJITEventListener for perf profiling support.: Restricted Project.
Apr 18 2019, 1:11 AM · Restricted Project