This is an archive of the discontinued LLVM Phabricator instance.

[DAGCombiner] Add node to the worklist in topological order after relegalization.
ClosedPublic

Authored by deadalnix on Aug 24 2019, 4:02 AM.

Reviewers

Commits

Summary

As per title.

Repository

rL LLVM

Build Status

Buildable 37241
Build 37240: arc lint + arc unit

LGTM

This revision is now accepted and ready to land.Aug 25 2019, 7:11 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

CodeGen/

SelectionDAG/

2 lines

Show First 20 Lines • Show All 1,658 Lines • ▼ Show 20 Lines	while (SDNode *N = getNextWorklistEntry()) {

// If this combine is running after legalizing the DAG, re-legalize any		// If this combine is running after legalizing the DAG, re-legalize any
// nodes pulled off the worklist.		// nodes pulled off the worklist.
if (Level == AfterLegalizeDAG) {		if (Level == AfterLegalizeDAG) {
SmallSetVector<SDNode *, 16> UpdatedNodes;		SmallSetVector<SDNode *, 16> UpdatedNodes;
bool NIsValid = DAG.LegalizeOp(N, UpdatedNodes);		bool NIsValid = DAG.LegalizeOp(N, UpdatedNodes);

for (SDNode *LN : UpdatedNodes) {		for (SDNode *LN : UpdatedNodes) {
AddToWorklist(LN);
AddUsersToWorklist(LN);		AddUsersToWorklist(LN);
		AddToWorklist(LN);
}		}
if (!NIsValid)		if (!NIsValid)
continue;		continue;
}		}

LLVM_DEBUG(dbgs() << "\nCombining: "; N->dump(&DAG));		LLVM_DEBUG(dbgs() << "\nCombining: "; N->dump(&DAG));

// Add any operands of the new node which have not yet been combined to the		// Add any operands of the new node which have not yet been combined to the
▲ Show 20 Lines • Show All 19,029 Lines • Show Last 20 Lines