This is an archive of the discontinued LLVM Phabricator instance.

[X86] Remove what little support we had for MPX
ClosedPublic

Authored by craig.topper on Aug 23 2019, 11:33 AM.

Details

Summary

-Deprecate -mmpx and -mno-mpx command line options
-Remove CPUID detection of mpx for -march=native
-Remove MPX from all CPUs
-Remove MPX preprocessor define

I've left the "mpx" string in the backend so we don't fail on old IR, but its not connected to anything.

gcc has also deprecated these command line options. https://www.phoronix.com/scan.php?page=news_item&px=GCC-Patch-To-Drop-MPX

Diff Detail

Repository
rL LLVM

Event Timeline

craig.topper created this revision.Aug 23 2019, 11:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2019, 11:33 AM
Herald added a subscriber: hiraditya. · View Herald Transcript

Update attributes in a couple tests that I forgot to check for

I think this needs adding to the draft 10.0 release notes as well.

llvm/lib/Target/X86/X86.td
244 ↗(On Diff #216912)

Add a note saying this was deprecated at llvm10? We're not great at removing deprecations (AutoUpgrade.....) but we should keep track.

xbolva00 added inline comments.
llvm/lib/Target/X86/X86InstrMPX.td
16 ↗(On Diff #216912)

Fix comment?

Add to clang and llvm release notes

Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2019, 11:18 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
RKSimon accepted this revision.Aug 29 2019, 1:22 AM

LGTM - please reword the X86InstrMPX.td comment like @xbolva00 suggested

This revision is now accepted and ready to land.Aug 29 2019, 1:22 AM
This revision was automatically updated to reflect the committed changes.