Page MenuHomePhabricator

clang-format: chromium style: Disable across-block include reordering.
ClosedPublic

Authored by thakis on Fri, Aug 23, 6:20 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

thakis created this revision.Fri, Aug 23, 6:20 AM

How's the work going to undo r357695 btw?

sammccall accepted this revision.Fri, Aug 23, 6:52 AM
sammccall added a subscriber: gribozavr.

How's the work going to undo r357695 btw?

I'm not sure anyone's chasing it at the moment, the focus has been on trying to improve the heuristic for cases that apply to all languages.
sThe heuristic was good enough to stick for C++, but uncovered lots of ambiguity in our style guide and working out what the stylists want has been slow. @gribozavr can give more details if you want them.

This revision is now accepted and ready to land.Fri, Aug 23, 6:52 AM
lebedev.ri retitled this revision from clang-format: Disable across-block include reordering. to clang-format: chromium style: Disable across-block include reordering..Fri, Aug 23, 6:54 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFri, Aug 23, 7:03 AM